apply clippy float optimization recommendations - #181
Open
Lucas-BRT wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applyes the following clippy nursery recomendations:
https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#imprecise_flops
https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#suboptimal_flops
Some of then can affect the readability (specially for the mathematical point of view), but the speed gain can have some benefit in the final product. i don't have the hardware to test, so i can't measure the exact speed gains in a specific processor in normal conditions, i will be grateful if someone can test if this have some real gains or we should only add a #[allow] for the linter.
Also, not related to this PR in specific, but in some places the codebase triggers other Linter warnings, like using the Struct name instead of Self, is some specific reason for this or i can open a PR to fix?