supports dynamic SVGs in layouts - #43119
Merged
Merged
Conversation
3nids
commented
May 7, 2021
Collaborator
|
Does this fix #42280 in the process? |
Member
Author
|
Yes this fixes #42280 |
nyalldawson
reviewed
May 9, 2021
nyalldawson
added
the
Requires Tests!
Member
Author
|
For me, this is ready to merge. |
3nids
removed
the
Requires Tests!
nirvn
reviewed
May 11, 2021
nirvn
approved these changes
May 11, 2021
nirvn
left a comment
nirvn
left a comment
Contributor
There was a problem hiding this comment.
🙏 thanks -- nice feature BTW.
* source line edit can be switched to image * SVG specific components can be hidden
also fix a UX bug where you couldn't switch between raster and SVG radios if the data defined property was active (unreported in tracker)
2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes a UX bug where you couldn't switch between raster and SVG radios if the data defined property was active
Switching now keeps the same source line edit which avoid the former tricks.
fixes #42280
This depends on #43099