Skip to content

do not return virtual file system path as default path in the file content widget (refs #37308) - #66342

Merged
alexbruy merged 1 commit into
qgis:masterfrom
alexbruy:file-content-widget-virtual-fs
Jun 5, 2026
Merged

do not return virtual file system path as default path in the file content widget (refs #37308)#66342
alexbruy merged 1 commit into
qgis:masterfrom
alexbruy:file-content-widget-virtual-fs

Conversation

@alexbruy

@alexbruy alexbruy commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

North arrow layout item uses :/images/north_arrows/layout_default_north_arrow.svg as a default image. When user tries to change image by clicking on "…" button the file dialog will use this path as a working directory (if this is a first time action and last used path is not saved in the QGIS settings) and as this is not an actual path on the filesystem, user will see a warning message "The file or folder does not exists".

We should not use virtual file system paths as a default path for file dialogs.

Refs #37308.

AI tool usage

  • AI tool(s) (Copilot, Claude, or something similar) supported my development of this PR. See our policy about AI tool use. Use of AI tools must be indicated. Failure to be honest might result in banning.
@github-actions github-actions Bot added this to the 4.2.0 milestone Jun 4, 2026
@github-actions github-actions Bot added the Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks label Jun 4, 2026
@alexbruy

alexbruy commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

I also removed duplicated call to setLastPathSettingsKey() in the QgsLayoutPictureWidget introduced in #43119, using the value which is set last.

@alexbruy
alexbruy merged commit 639438c into qgis:master Jun 5, 2026
31 checks passed
@alexbruy
alexbruy deleted the file-content-widget-virtual-fs branch June 5, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks

2 participants