[CORRUPTED] Synthetic Benchmark PR #139798 - Fix interpolation for data points at bucket boundaries#52
Open
tomerqodo wants to merge 13 commits intobase_pr_139798_20251230_8362from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR elastic#139798
Type: Corrupted (contains bugs)
Original PR Title: Fix interpolation for data points at bucket boundaries
Original PR Description: Interpolation logic didn't cover the case where there's a single data point at the lower boundary and just a previous state, or a single point at the upper boundary and just a next state. If this happens, the data point matches the only interpolated value, so there are no 2 data points within the state to calculate the delta. The fix is to use the delta from the closest data point in the adjacent state.
While there, added the following fixes to the randomized testing suite:
Fixes elastic#139732
Original PR URL: elastic#139798