Skip to content

Conversation

@ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Nov 12, 2025

Before:
image

After:
image

Closes APP-477

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!
@ericpgreen2 ericpgreen2 self-assigned this Nov 12, 2025
@nishantmonu51
Copy link
Collaborator

@ericpgreen2 : Is it ready to be reviewed?

@ericpgreen2 ericpgreen2 marked this pull request as ready for review December 8, 2025 21:08
@ericpgreen2
Copy link
Contributor Author

@ericpgreen2 : Is it ready to be reviewed?

Ready now!

Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few hardcoded styles vs tailwind. Please take a look at the new components and replace then.

Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits but LGTM.

One thing to note, we use non-theme friendly colors like text-gray-xxx quite a bit in chat. We might need to address this ASAP since this is out of feature flag. But out of scope of this PR

@ericpgreen2 ericpgreen2 merged commit d40a001 into main Dec 12, 2025
14 checks passed
@ericpgreen2 ericpgreen2 deleted the ai-thinking-aesthetics branch December 12, 2025 15:22
ericpgreen2 added a commit that referenced this pull request Dec 12, 2025
* WIP

* Progress

* Code cleanup

* More code colocation

* Improved semantics

* Remove chart block's top margin

* Add "planning next moves" block

* Clean-up `UserMessage` post merge

* Use `ListTools` API for tool metadata

* Tweak spacing

* Prettier

* Refactor message render router

* Cleanups

* Nits

* Re-characterize "planning" as "working" and use it in more cases

* Icons for developer tools

* Move `create_chart` and `write_file` tools outside the thinking block

* Create `tools` dir

* Tweak header of `FileDiffBlock`

* Tweak loading states

* Self review

* Review

* Remove sticky header behavior

* Fix autoscroll behavior

* Use ShadCN `Collapsible` component

* Don't hardcode colors in `FileDiffBlock`
k-anshul pushed a commit that referenced this pull request Dec 18, 2025
* WIP

* Progress

* Code cleanup

* More code colocation

* Improved semantics

* Remove chart block's top margin

* Add "planning next moves" block

* Clean-up `UserMessage` post merge

* Use `ListTools` API for tool metadata

* Tweak spacing

* Prettier

* Refactor message render router

* Cleanups

* Nits

* Re-characterize "planning" as "working" and use it in more cases

* Icons for developer tools

* Move `create_chart` and `write_file` tools outside the thinking block

* Create `tools` dir

* Tweak header of `FileDiffBlock`

* Tweak loading states

* Self review

* Review

* Remove sticky header behavior

* Fix autoscroll behavior

* Use ShadCN `Collapsible` component

* Don't hardcode colors in `FileDiffBlock`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants