-
Notifications
You must be signed in to change notification settings - Fork 159
design (AI): Improve the AI's "thinking" aesthetic #8316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ericpgreen2 : Is it ready to be reviewed? |
Ready now! |
AdityaHegde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few hardcoded styles vs tailwind. Please take a look at the new components and replace then.
web-common/src/features/chat/core/messages/thinking/ThinkingBlock.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits but LGTM.
One thing to note, we use non-theme friendly colors like text-gray-xxx quite a bit in chat. We might need to address this ASAP since this is out of feature flag. But out of scope of this PR
web-common/src/features/chat/core/messages/file-diff/FileDiffBlock.svelte
Outdated
Show resolved
Hide resolved
web-common/src/features/chat/core/messages/thinking/ThinkingBlock.svelte
Outdated
Show resolved
Hide resolved
* WIP * Progress * Code cleanup * More code colocation * Improved semantics * Remove chart block's top margin * Add "planning next moves" block * Clean-up `UserMessage` post merge * Use `ListTools` API for tool metadata * Tweak spacing * Prettier * Refactor message render router * Cleanups * Nits * Re-characterize "planning" as "working" and use it in more cases * Icons for developer tools * Move `create_chart` and `write_file` tools outside the thinking block * Create `tools` dir * Tweak header of `FileDiffBlock` * Tweak loading states * Self review * Review * Remove sticky header behavior * Fix autoscroll behavior * Use ShadCN `Collapsible` component * Don't hardcode colors in `FileDiffBlock`
* WIP * Progress * Code cleanup * More code colocation * Improved semantics * Remove chart block's top margin * Add "planning next moves" block * Clean-up `UserMessage` post merge * Use `ListTools` API for tool metadata * Tweak spacing * Prettier * Refactor message render router * Cleanups * Nits * Re-characterize "planning" as "working" and use it in more cases * Icons for developer tools * Move `create_chart` and `write_file` tools outside the thinking block * Create `tools` dir * Tweak header of `FileDiffBlock` * Tweak loading states * Self review * Review * Remove sticky header behavior * Fix autoscroll behavior * Use ShadCN `Collapsible` component * Don't hardcode colors in `FileDiffBlock`
Before:

After:

Closes APP-477
Checklist: