Show file change diffs in the Rill developer AI response #8436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add package. Update package-lock.json
ericpgreen2
approved these changes
Dec 4, 2025
Contributor
ericpgreen2
left a comment
ericpgreen2
left a comment
There was a problem hiding this comment.
As discussed, we'll have to reconcile the message rendering code in this PR with the message rendering refactor in this PR, but I'm happy to merge this as-is and do that myself.
Though before merge, tagging @begelundmuller for the backend review.
Comment on lines
+84
to
+105
| /** | ||
| * Data structure for write_file tool call arguments | ||
| */ | ||
| export interface WriteFileCallData { | ||
| path: string; | ||
| contents: string; | ||
| } | ||
|
|
||
| /** | ||
| * Data structure for write_file tool result | ||
| */ | ||
| export interface WriteFileResultData { | ||
| diff?: string; | ||
| is_new_file?: boolean; | ||
| resources?: Array<{ | ||
| kind: string; | ||
| name: string; | ||
| reconcile_status: string; | ||
| reconcile_error: string; | ||
| }>; | ||
| parse_error?: string; | ||
| } |
Contributor
There was a problem hiding this comment.
@begelundmuller can we define these types in a protobuf file & generate Typescript types for the frontend to use?
Collaborator
There was a problem hiding this comment.
Lets take that as a follow up.
AdityaHegde
force-pushed
the
show-diff
branch
from
a2a6484 to
052398b
Compare
Collaborator
|
Merging for now to be available for tomorrow's demo. |
AdityaHegde
added a commit
that referenced
this pull request
Dec 5, 2025
* Sample show file change diffs in the AI response add package. Update package-lock.json * Touch-up CSS * Fix CI --------- Co-authored-by: Eric P Green <ericpgreen2@gmail.com> Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype to show edit diff in AI responses. The UI code needs a deeper review as its claude gen.
Checklist: