Fix ublk uring usage due to using SQE128 #25987
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When IORING_SETUP_SQE128 is set, the kernel uses 128-byte spacing instead of 64, and with IORING_SETUP_CQE32 it uses 32-byte CQE spacing instead of 16 bytes. This was causing problems when attempting to use zig for a linux ublk server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When IORING_SETUP_SQE128 is set, the kernel uses 128-byte spacing instead of 64, and with IORING_SETUP_CQE32 it uses 32-byte CQE spacing instead of 16 bytes.
This was causing problems when attempting to use zig for a linux ublk server.
I'm very new to zig, and I had claude help me to make a reproduction. I stuck that at https://github.com/graveland/zig-iouring-bug-reproduction