Skip to content

docs: improve custom render value S2 Picker example#9682

Merged
reidbarber merged 4 commits intomainfrom
picker-custom-render-value-docs-fixes
Feb 19, 2026
Merged

docs: improve custom render value S2 Picker example#9682
reidbarber merged 4 commits intomainfrom
picker-custom-render-value-docs-fixes

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Feb 18, 2026 •
edited
Loading

  • Uses AvatarGroup for the list of avatars in the example
  • Collapses the users array in the docs

Also includes a storybook fix found in testing (v3 TreeView Empty Tree story wasn't actually empty).

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check docs example and verify:

  • AvatarGroup is rendered
  • user array is collapsed in code example

and ensure the fixed story has an empty tree.

🧢 Your Project:
@github-actions github-actions bot added the S2 label Feb 18, 2026
@reidbarber reidbarber changed the title docs: improve custom Render Value Picker example Feb 18, 2026
@rspbot
Copy link

rspbot commented Feb 18, 2026

Build successful! 🎉
@github-actions github-actions bot added the v3 label Feb 19, 2026
@rspbot
Copy link

rspbot commented Feb 19, 2026

Build successful! 🎉
LFDanLu
LFDanLu previously approved these changes Feb 19, 2026
View reviewed changes
@rspbot
Copy link

rspbot commented Feb 19, 2026

Build successful! 🎉
@rspbot
Copy link

rspbot commented Feb 19, 2026

Build successful! 🎉
@reidbarber reidbarber enabled auto-merge February 19, 2026 21:39
dannify
dannify approved these changes Feb 19, 2026
View reviewed changes
Copy link
Member

@dannify dannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR but can we do anything to help with overflow and/or restricting what goes in here?
@reidbarber reidbarber added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main with commit 6073f1c Feb 19, 2026
30 checks passed
@reidbarber reidbarber deleted the picker-custom-render-value-docs-fixes branch February 19, 2026 21:56
pioug pushed a commit to pioug/react-spectrum that referenced this pull request Feb 28, 2026
Merge remote-tracking branch 'origin/main' into codex/vue-migration-b…
e68850a 
…aseline-tracker

* origin/main:
  feat(S2): S2 ListView (adobe#8878)
  refactor: Centralize expandedKeys logic in TreeCollection (adobe#9711)
  chore: Warn if user has interactive elements in their custom Picker value (adobe#9710)
  feat: S2 unavailable menu item (adobe#9657)
  fix: Ensure that opening a submenu via enter/space moves focus to first item in submenu (adobe#9691)
  fix: prevent docs crash by making template elements always append children into .content (adobe#9703)
  docs(RAC): Add TreeSection docs (adobe#9699)
  docs(S2): add Typography search view (adobe#9524)
  docs(S2): fix clipping in Picker custom value AvatarGroup example (adobe#9702)
  fix: patch additional methods so React doesnt break with template elements (adobe#9385)
  tentative fix (adobe#9635)
  docs(S2): fix icon import clipboard content to add underscore for icons starting with number (adobe#9698)
  feat(S2): add ActionBar support to TreeView (adobe#9695)
  fix: combobox interactoutside (adobe#9646)
  fix: skip native Date fast path when local timezone is overridden via setLocalTimeZone (adobe#9678)
  chore: update storybook to 9 (adobe#8634)
  docs: improve custom render value S2 Picker example (adobe#9682)

# Conflicts:
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment