Skip to content

fix: prevent docs crash by making template elements always append children into .content#9703

Merged
snowystinger merged 2 commits intomainfrom
apply_to_all_templates
Feb 27, 2026
Merged

fix: prevent docs crash by making template elements always append children into .content#9703
snowystinger merged 2 commits intomainfrom
apply_to_all_templates

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Feb 26, 2026

follow up to #9385

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to S2 Picker docs. Type any description in the first example's description control, it should apply without crashing. Also try going to another page and coming back to the Picker page and adding a description.

🧢 Your Project:

RSP
@github-actions github-actions bot added the RAC label Feb 26, 2026
@rspbot
Copy link

rspbot commented Feb 26, 2026

Build successful! 🎉
@snowystinger snowystinger added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit d974b93 Feb 27, 2026
29 checks passed
@snowystinger snowystinger deleted the apply_to_all_templates branch February 27, 2026 05:25
pioug pushed a commit to pioug/react-spectrum that referenced this pull request Feb 28, 2026
Merge remote-tracking branch 'origin/main' into codex/vue-migration-b…
e68850a 
…aseline-tracker

* origin/main:
  feat(S2): S2 ListView (adobe#8878)
  refactor: Centralize expandedKeys logic in TreeCollection (adobe#9711)
  chore: Warn if user has interactive elements in their custom Picker value (adobe#9710)
  feat: S2 unavailable menu item (adobe#9657)
  fix: Ensure that opening a submenu via enter/space moves focus to first item in submenu (adobe#9691)
  fix: prevent docs crash by making template elements always append children into .content (adobe#9703)
  docs(RAC): Add TreeSection docs (adobe#9699)
  docs(S2): add Typography search view (adobe#9524)
  docs(S2): fix clipping in Picker custom value AvatarGroup example (adobe#9702)
  fix: patch additional methods so React doesnt break with template elements (adobe#9385)
  tentative fix (adobe#9635)
  docs(S2): fix icon import clipboard content to add underscore for icons starting with number (adobe#9698)
  feat(S2): add ActionBar support to TreeView (adobe#9695)
  fix: combobox interactoutside (adobe#9646)
  fix: skip native Date fast path when local timezone is overridden via setLocalTimeZone (adobe#9678)
  chore: update storybook to 9 (adobe#8634)
  docs: improve custom render value S2 Picker example (adobe#9682)

# Conflicts:
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment