Skip to content

docs(S2): fix clipping in Picker custom value AvatarGroup example#9702

Merged
reidbarber merged 1 commit intomainfrom
docs-s2-picker-render-value-fix
Feb 26, 2026
Merged

docs(S2): fix clipping in Picker custom value AvatarGroup example#9702
reidbarber merged 1 commit intomainfrom
docs-s2-picker-render-value-fix

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Feb 26, 2026

Fixes the AvatarGroup getting clipped when rendered as a custom value in the Picker.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test the docs example and make sure the avatar group doesn't get clipped.

🧢 Your Project:

@github-actions github-actions bot added the S2 label Feb 26, 2026
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with it, though a bit unfortunate that it doesn't left align the avatar with the placeholder
Do you have a screenshot of what it looks like without this change? I'm not sure where this ask came from

@reidbarber
Copy link
Member Author

Screenshot 2026-02-26 at 4 17 23 PM

@snowystinger Found in testing yesterday, the group gets barely clipped on the left.

@reidbarber reidbarber enabled auto-merge February 26, 2026 22:18
@reidbarber reidbarber added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit 04b7380 Feb 26, 2026
30 checks passed
@reidbarber reidbarber deleted the docs-s2-picker-render-value-fix branch February 26, 2026 23:03
pioug pushed a commit to pioug/react-spectrum that referenced this pull request Feb 28, 2026
…aseline-tracker

* origin/main:
  feat(S2): S2 ListView (adobe#8878)
  refactor: Centralize expandedKeys logic in TreeCollection (adobe#9711)
  chore: Warn if user has interactive elements in their custom Picker value (adobe#9710)
  feat: S2 unavailable menu item (adobe#9657)
  fix: Ensure that opening a submenu via enter/space moves focus to first item in submenu (adobe#9691)
  fix: prevent docs crash by making template elements always append children into .content (adobe#9703)
  docs(RAC): Add TreeSection docs (adobe#9699)
  docs(S2): add Typography search view (adobe#9524)
  docs(S2): fix clipping in Picker custom value AvatarGroup example (adobe#9702)
  fix: patch additional methods so React doesnt break with template elements (adobe#9385)
  tentative fix (adobe#9635)
  docs(S2): fix icon import clipboard content to add underscore for icons starting with number (adobe#9698)
  feat(S2): add ActionBar support to TreeView (adobe#9695)
  fix: combobox interactoutside (adobe#9646)
  fix: skip native Date fast path when local timezone is overridden via setLocalTimeZone (adobe#9678)
  chore: update storybook to 9 (adobe#8634)
  docs: improve custom render value S2 Picker example (adobe#9682)

# Conflicts:
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment