Skip to content

[cisco_ise] Add Cisco ISE package. - #2855

Merged
andrewkroh merged 11 commits into
elastic:mainfrom
vinit-chauhan:package_cisco_ise
Apr 23, 2022
Merged

[cisco_ise] Add Cisco ISE package.#2855
andrewkroh merged 11 commits into
elastic:mainfrom
vinit-chauhan:package_cisco_ise

Conversation

@vinit-chauhan

@vinit-chauhan vinit-chauhan commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Generated the skeleton of the Cisco ISE integration package.
  • Added a data stream.
  • Added data collection logic to the data stream.
  • Added the ingest pipeline for the data stream.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files
  • Added dashboards and visualizations.
  • Added test for pipeline for the data stream.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.17.0 || ^8.0.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/cisco_ise directory.
  • Run the following command to run tests.

elastic-package test

Screenshots

image
image
image
image
image
@vinit-chauhan
vinit-chauhan requested a review from a team as a code owner March 21, 2022 12:57
@elasticmachine

elasticmachine commented Mar 21, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-23T03:39:29.209+0000

  • Duration: 14 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 90
Skipped 0
Total 90

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Mar 21, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@andrewkroh
andrewkroh requested a review from a team March 24, 2022 13:25
@andrewkroh

andrewkroh commented Mar 24, 2022

Copy link
Copy Markdown
Contributor

/test
efd6
efd6 reviewed Mar 28, 2022
View reviewed changes
Comment thread packages/cisco_ise/data_stream/log/agent/stream/tcp.yml.hbs Outdated
Comment thread packages/cisco_ise/data_stream/log/agent/stream/udp.yml.hbs Outdated
Comment thread ...ages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/pipeline_threat_centric_nac.yml Outdated
Comment thread ...a_stream/log/elasticsearch/ingest_pipeline/pipeline_administrative_and_operational_audit.yml Outdated
Comment thread ...a_stream/log/elasticsearch/ingest_pipeline/pipeline_administrative_and_operational_audit.yml Outdated
Comment thread ...ages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/pipeline_radius_diagnostics.yml Outdated
Comment thread packages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/pipeline_failed_attempts.yml Outdated
Comment thread ...a_stream/log/elasticsearch/ingest_pipeline/pipeline_administrative_and_operational_audit.yml Outdated
Comment thread ...e/data_stream/log/elasticsearch/ingest_pipeline/pipeline_authentication_flow_diagnostics.yml Outdated
Comment thread packages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/pipeline_guest.yml Outdated
@vinit-chauhan
vinit-chauhan requested a review from efd6 April 4, 2022 04:38
@efd6

efd6 commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

/test
@efd6

efd6 commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

Looks like you need to rebuild: elastic-package build.
@vinit-chauhan

vinit-chauhan commented Apr 4, 2022

Copy link
Copy Markdown
Contributor Author

Yes, @efd6 I have recompiled the README with latest elastic-package.
@andrewkroh

andrewkroh commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

/test
@andrewkroh

andrewkroh commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

/test
andrewkroh
andrewkroh reviewed Apr 13, 2022
View reviewed changes
Comment thread packages/cisco_ise/_dev/build/docs/README.md Outdated
Comment thread packages/cisco_ise/_dev/build/docs/README.md
Comment thread packages/cisco_ise/data_stream/log/sample_event.json Outdated
Comment thread packages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/pipeline_ad_connector.yml Outdated
Comment thread packages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/pipeline_ad_connector.yml Outdated
Comment thread ...a_stream/log/elasticsearch/ingest_pipeline/pipeline_administrative_and_operational_audit.yml Outdated
Comment thread ...a_stream/log/elasticsearch/ingest_pipeline/pipeline_administrative_and_operational_audit.yml Outdated
@andrewkroh

andrewkroh commented Apr 18, 2022

Copy link
Copy Markdown
Contributor

/test
andrewkroh
andrewkroh reviewed Apr 23, 2022
View reviewed changes
Comment thread packages/cisco_ise/_dev/build/docs/README.md Outdated
@andrewkroh
andrewkroh merged commit 2c4a768 into elastic:main Apr 23, 2022
v1v added a commit to v1v/integrations that referenced this pull request Apr 25, 2022
@v1v
'feature/labels-cloud-ephemeral-components' of github.com:v1v/integr…
02b4c7f 
…ations into feature/labels-cloud-ephemeral-components

* 'feature/labels-cloud-ephemeral-components' of github.com:v1v/integrations: (23 commits)
  use branch
  standardise labels/tags
  Update .ci/Jenkinsfile
  [ci][terraform][aws] tags with metadata
  Bump github.com/elastic/elastic-package from 0.46.0 to 0.47.0 (elastic#3182)
  Spring boot package [Memory - data stream] (elastic#2979)
  [cisco_ise] Add Cisco ISE package (elastic#2855)
  [apache_spark][executor] Add Apache Spark package with Executor data stream (elastic#2943)
  [apache_spark][driver] Add Apache Spark package with Driver data stream (elastic#2945)
  cisco_duo: simplify grok expression for handling ports (elastic#3170)
  cisco_duo: fix handling of IP addresses with port numbers (elastic#3117)
  [sophos] Various improvements and log samples from 18.5 (elastic#3127)
  [cisco_asa] fix visualizations (elastic#3146)
  [apache_spark][application] Add Apache Spark package with Application data stream (elastic#2941)
  Fix pagination bug that skipped events when more than one page is present. (elastic#3140)
  Cis k8s name migration (elastic#3113)
  remove exported fields; these will be added to Kibana docs instead (elastic#3093)
  Exclude ecosystem as owner of subdirectories of packages (elastic#3132)
  [awsfargate] bump package version (elastic#3130)
  add first csp rule template (elastic#3081)
  ...
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Aug 13, 2024
@vinit-chauhan
vinit-chauhan deleted the package_cisco_ise branch April 1, 2026 23:57
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@vinit-chauhan @darshan-elastic @andrewkroh
[cisco_ise] Add Cisco ISE package (elastic#2855)
10d8d10 
Generated the skeleton of the Cisco ISE integration package.
Added a data stream.
Added data collection logic to the data stream.
Added the ingest pipeline for the data stream.
Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files
Added dashboards and visualizations.
Added test for pipeline for the data stream.
Added system test cases for the data stream.

Co-authored-by: Darshan Lukhi <darshan.lukhi@elastic.co>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@github-actions github-actions Bot mentioned this pull request May 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:cisco_ise Cisco ISE New Integration Issue or pull request for creating a new integration package.

6 participants

@vinit-chauhan @elasticmachine @andrewkroh @efd6 @mtojek @darshan-elastic