Skip to content

cisco_duo: simplify grok expression for handling ports - #3170

Merged
efd6 merged 2 commits into
elastic:mainfrom
efd6:3117-cisco_duo
Apr 22, 2022
Merged

cisco_duo: simplify grok expression for handling ports#3170
efd6 merged 2 commits into
elastic:mainfrom
efd6:3117-cisco_duo

Conversation

@efd6

@efd6 efd6 commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Simplifies the grok pattern for ports.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6
efd6 requested a review from a team as a code owner April 22, 2022 01:20
@efd6 efd6 self-assigned this Apr 22, 2022
@elasticmachine

elasticmachine commented Apr 22, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
efd6
efd6 commented Apr 22, 2022
View reviewed changes
Comment thread packages/cisco_duo/changelog.yml Outdated
@elasticmachine

elasticmachine commented Apr 22, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-22T01:21:19.924+0000

  • Duration: 19 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 54
Skipped 0
Total 54

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@efd6
efd6 merged commit e01918f into elastic:main Apr 22, 2022
@efd6
efd6 deleted the 3117-cisco_duo branch April 22, 2022 01:40
v1v added a commit to v1v/integrations that referenced this pull request Apr 25, 2022
@v1v
'feature/labels-cloud-ephemeral-components' of github.com:v1v/integr…
02b4c7f 
…ations into feature/labels-cloud-ephemeral-components

* 'feature/labels-cloud-ephemeral-components' of github.com:v1v/integrations: (23 commits)
  use branch
  standardise labels/tags
  Update .ci/Jenkinsfile
  [ci][terraform][aws] tags with metadata
  Bump github.com/elastic/elastic-package from 0.46.0 to 0.47.0 (elastic#3182)
  Spring boot package [Memory - data stream] (elastic#2979)
  [cisco_ise] Add Cisco ISE package (elastic#2855)
  [apache_spark][executor] Add Apache Spark package with Executor data stream (elastic#2943)
  [apache_spark][driver] Add Apache Spark package with Driver data stream (elastic#2945)
  cisco_duo: simplify grok expression for handling ports (elastic#3170)
  cisco_duo: fix handling of IP addresses with port numbers (elastic#3117)
  [sophos] Various improvements and log samples from 18.5 (elastic#3127)
  [cisco_asa] fix visualizations (elastic#3146)
  [apache_spark][application] Add Apache Spark package with Application data stream (elastic#2941)
  Fix pagination bug that skipped events when more than one page is present. (elastic#3140)
  Cis k8s name migration (elastic#3113)
  remove exported fields; these will be added to Kibana docs instead (elastic#3093)
  Exclude ecosystem as owner of subdirectories of packages (elastic#3132)
  [awsfargate] bump package version (elastic#3130)
  add first csp rule template (elastic#3081)
  ...
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
cisco_duo: simplify grok expression for handling ports (elastic#3170)
2c009fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_duo Cisco Duo

3 participants

@efd6 @elasticmachine @andrewkroh