Skip to content

[cisco_asa] fix visualizations - #3146

Merged
leehinman merged 1 commit into
elastic:mainfrom
leehinman:3142_cisco_asa_visualizations
Apr 21, 2022
Merged

[cisco_asa] fix visualizations#3146
leehinman merged 1 commit into
elastic:mainfrom
leehinman:3142_cisco_asa_visualizations

Conversation

@leehinman

@leehinman leehinman commented Apr 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • stop using cisco.asa.message_id in visualization, field no longer populated.
  • use data_stream to limit to cisco asa events.
  • use event.code instead which has same info as cisco.asa.message_id did

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before

Screen Shot 2022-04-20 at 12 49 09

After

Screen Shot 2022-04-20 at 12 30 28
@leehinman
leehinman requested a review from a team as a code owner April 20, 2022 17:54
@leehinman leehinman added bug Something isn't working, use only for issues Team:Security-External Integrations labels Apr 20, 2022
@elasticmachine

elasticmachine commented Apr 20, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@leehinman
leehinman force-pushed the 3142_cisco_asa_visualizations branch from 7bf564c to 844ee92 Compare April 20, 2022 17:56
@elasticmachine

elasticmachine commented Apr 20, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-21T14:09:24.880+0000

  • Duration: 15 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 27
Skipped 0
Total 27

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
efd6
efd6 approved these changes Apr 20, 2022
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after elastic-package build
@leehinman
[cisco_asa] fix visualizations
5d93e34 
- stop using `cisco.asa.message_id` in visualization
- use data_stream to limit to cisco asa events
- use event.code instead which has same info as `cisco.asa.message_id`
  did

Closes elastic#3142
@leehinman
leehinman force-pushed the 3142_cisco_asa_visualizations branch from 844ee92 to 5d93e34 Compare April 21, 2022 14:09
@leehinman
leehinman merged commit 7d51097 into elastic:main Apr 21, 2022
v1v added a commit to v1v/integrations that referenced this pull request Apr 25, 2022
@v1v
'feature/labels-cloud-ephemeral-components' of github.com:v1v/integr…
02b4c7f 
…ations into feature/labels-cloud-ephemeral-components

* 'feature/labels-cloud-ephemeral-components' of github.com:v1v/integrations: (23 commits)
  use branch
  standardise labels/tags
  Update .ci/Jenkinsfile
  [ci][terraform][aws] tags with metadata
  Bump github.com/elastic/elastic-package from 0.46.0 to 0.47.0 (elastic#3182)
  Spring boot package [Memory - data stream] (elastic#2979)
  [cisco_ise] Add Cisco ISE package (elastic#2855)
  [apache_spark][executor] Add Apache Spark package with Executor data stream (elastic#2943)
  [apache_spark][driver] Add Apache Spark package with Driver data stream (elastic#2945)
  cisco_duo: simplify grok expression for handling ports (elastic#3170)
  cisco_duo: fix handling of IP addresses with port numbers (elastic#3117)
  [sophos] Various improvements and log samples from 18.5 (elastic#3127)
  [cisco_asa] fix visualizations (elastic#3146)
  [apache_spark][application] Add Apache Spark package with Application data stream (elastic#2941)
  Fix pagination bug that skipped events when more than one page is present. (elastic#3140)
  Cis k8s name migration (elastic#3113)
  remove exported fields; these will be added to Kibana docs instead (elastic#3093)
  Exclude ecosystem as owner of subdirectories of packages (elastic#3132)
  [awsfargate] bump package version (elastic#3130)
  add first csp rule template (elastic#3081)
  ...
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
@leehinman
leehinman deleted the 3142_cisco_asa_visualizations branch July 18, 2022 18:04
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@leehinman
[cisco_asa] fix visualizations (elastic#3146)
55ee0a8 
- stop using `cisco.asa.message_id` in visualization
- use data_stream to limit to cisco asa events
- use event.code instead which has same info as `cisco.asa.message_id` did

Closes elastic#3142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

3 participants

@leehinman @elasticmachine @efd6