[ResponseOps][MaintenanceWindow] Remove category selection step when adding filters to maintenance windows#227888
Conversation
...ackages/shared/kbn-alerts-ui-shared/src/common/hooks/use_fetch_alerts_fields_with_new_api.ts
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-alerts-ui-shared/src/alerts_search_bar/index.tsx
Outdated
Show resolved
Hide resolved
umbopepato
left a comment
There was a problem hiding this comment.
LGTM, thanks for removing this complexity from MWs Janki! 🎉
I left a couple of nit comments
Some suggestions: Maintenance Window in Progress Ongoing Maintenance Window Note that we aim to enhance the way we display this type of message to make it more contextual, as it currently doesn't provide exact information about which ones are affected. |
…ogy, updated callout
Thanks @joana-cps Updated to use existing message. Added link to go to maintenance windows page
|
banderror
left a comment
There was a problem hiding this comment.
The change to x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/maintenance_windows/maintenance_window_callout.cy.ts LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
|
…age (#230971) Closes #230768 ## Summary I removed the banner as discussed offline and we now only display the `Archive` button. <img width="1374" height="126" alt="Screenshot 2025-08-07 at 13 39 36" src="https://github.com/user-attachments/assets/6527fd55-5a4f-4015-bb82-899845ae9b0e" /> The modal text was reworded (@nastasha-solomon could you please proofread the copy?). <img width="1005" height="409" alt="Screenshot 2025-08-07 at 13 29 41" src="https://github.com/user-attachments/assets/989e9b19-9f96-4c2f-8757-d13fa45f744b" /> <details><summary>Something else I noticed was that we have an ugly margin in the edit page, right below the `Filters` section.</summary><img width="1416" height="370" alt="Screenshot 2025-08-07 at 13 24 04" src="https://github.com/user-attachments/assets/31b7e7c1-d1a4-436e-a121-f56d64ec7598" /></details> I was going to remove it, but looking at the code, [this PR](#227888) should fix it, so I didn't touch it.
…adding filters to maintenance windows (elastic#227888) ## Summary Fixes elastic#226808 This PR removes category selection step when adding filters while creating or editing maintenance windows. It leverages [new alert fields api ](elastic#222032) to fetch alert fields across all solutions for filtering. <details><summary>Before</summary> <img width="1386" height="890" alt="image" src="https://github.com/user-attachments/assets/c051365c-eb94-492f-a58b-1e7067f39810" /> </details> <details><summary>After</summary> <img width="720" height="436" alt="image" src="https://github.com/user-attachments/assets/267b77c3-a7b9-4785-8313-51532787487d" /> </details> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Release Note Users can now add filters to maintenance windows based on alert fields from all solutions, without needing to select a category first. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…age (elastic#230971) Closes elastic#230768 ## Summary I removed the banner as discussed offline and we now only display the `Archive` button. <img width="1374" height="126" alt="Screenshot 2025-08-07 at 13 39 36" src="https://github.com/user-attachments/assets/6527fd55-5a4f-4015-bb82-899845ae9b0e" /> The modal text was reworded (@nastasha-solomon could you please proofread the copy?). <img width="1005" height="409" alt="Screenshot 2025-08-07 at 13 29 41" src="https://github.com/user-attachments/assets/989e9b19-9f96-4c2f-8757-d13fa45f744b" /> <details><summary>Something else I noticed was that we have an ugly margin in the edit page, right below the `Filters` section.</summary><img width="1416" height="370" alt="Screenshot 2025-08-07 at 13 24 04" src="https://github.com/user-attachments/assets/31b7e7c1-d1a4-436e-a121-f56d64ec7598" /></details> I was going to remove it, but looking at the code, [this PR](elastic#227888) should fix it, so I didn't touch it.
…adding filters to maintenance windows (elastic#227888) ## Summary Fixes elastic#226808 This PR removes category selection step when adding filters while creating or editing maintenance windows. It leverages [new alert fields api ](elastic#222032) to fetch alert fields across all solutions for filtering. <details><summary>Before</summary> <img width="1386" height="890" alt="image" src="https://github.com/user-attachments/assets/c051365c-eb94-492f-a58b-1e7067f39810" /> </details> <details><summary>After</summary> <img width="720" height="436" alt="image" src="https://github.com/user-attachments/assets/267b77c3-a7b9-4785-8313-51532787487d" /> </details> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Release Note Users can now add filters to maintenance windows based on alert fields from all solutions, without needing to select a category first. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…age (elastic#230971) Closes elastic#230768 ## Summary I removed the banner as discussed offline and we now only display the `Archive` button. <img width="1374" height="126" alt="Screenshot 2025-08-07 at 13 39 36" src="https://github.com/user-attachments/assets/6527fd55-5a4f-4015-bb82-899845ae9b0e" /> The modal text was reworded (@nastasha-solomon could you please proofread the copy?). <img width="1005" height="409" alt="Screenshot 2025-08-07 at 13 29 41" src="https://github.com/user-attachments/assets/989e9b19-9f96-4c2f-8757-d13fa45f744b" /> <details><summary>Something else I noticed was that we have an ugly margin in the edit page, right below the `Filters` section.</summary><img width="1416" height="370" alt="Screenshot 2025-08-07 at 13 24 04" src="https://github.com/user-attachments/assets/31b7e7c1-d1a4-436e-a121-f56d64ec7598" /></details> I was going to remove it, but looking at the code, [this PR](elastic#227888) should fix it, so I didn't touch it.


Summary
Fixes #226808
This PR removes category selection step when adding filters while creating or editing maintenance windows. It leverages new alert fields api to fetch alert fields across all solutions for filtering.
Before
After
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Release Note
Users can now add filters to maintenance windows based on alert fields from all solutions, without needing to select a category first.