[ResponseOps][MaintenanceWindow] Remove archive banner from edit MW page#230971
Merged
adcoelho merged 3 commits intoelastic:mainfrom Aug 12, 2025
Merged
[ResponseOps][MaintenanceWindow] Remove archive banner from edit MW page#230971adcoelho merged 3 commits intoelastic:mainfrom
adcoelho merged 3 commits intoelastic:mainfrom
Conversation
adcoelho
added
enhancement
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
adcoelho
force-pushed
the
ui-archive-mw
branch
from
20c2fd7 to
5f6b32a
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @adcoelho |
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…age (elastic#230971) Closes elastic#230768 ## Summary I removed the banner as discussed offline and we now only display the `Archive` button. <img width="1374" height="126" alt="Screenshot 2025-08-07 at 13 39 36" src="https://github.com/user-attachments/assets/6527fd55-5a4f-4015-bb82-899845ae9b0e" /> The modal text was reworded (@nastasha-solomon could you please proofread the copy?). <img width="1005" height="409" alt="Screenshot 2025-08-07 at 13 29 41" src="https://github.com/user-attachments/assets/989e9b19-9f96-4c2f-8757-d13fa45f744b" /> <details><summary>Something else I noticed was that we have an ugly margin in the edit page, right below the `Filters` section.</summary><img width="1416" height="370" alt="Screenshot 2025-08-07 at 13 24 04" src="https://github.com/user-attachments/assets/31b7e7c1-d1a4-436e-a121-f56d64ec7598" /></details> I was going to remove it, but looking at the code, [this PR](elastic#227888) should fix it, so I didn't touch it.
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
…age (elastic#230971) Closes elastic#230768 ## Summary I removed the banner as discussed offline and we now only display the `Archive` button. <img width="1374" height="126" alt="Screenshot 2025-08-07 at 13 39 36" src="https://github.com/user-attachments/assets/6527fd55-5a4f-4015-bb82-899845ae9b0e" /> The modal text was reworded (@nastasha-solomon could you please proofread the copy?). <img width="1005" height="409" alt="Screenshot 2025-08-07 at 13 29 41" src="https://github.com/user-attachments/assets/989e9b19-9f96-4c2f-8757-d13fa45f744b" /> <details><summary>Something else I noticed was that we have an ugly margin in the edit page, right below the `Filters` section.</summary><img width="1416" height="370" alt="Screenshot 2025-08-07 at 13 24 04" src="https://github.com/user-attachments/assets/31b7e7c1-d1a4-436e-a121-f56d64ec7598" /></details> I was going to remove it, but looking at the code, [this PR](elastic#227888) should fix it, so I didn't touch it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230768
Summary
I removed the banner as discussed offline and we now only display the
Archivebutton.The modal text was reworded (@nastasha-solomon could you please proofread the copy?).
Something else I noticed was that we have an ugly margin in the edit page, right below the `Filters` section.