fix: Disable Helm test pod when test.enabled=false

[lindhe]

What this PR does / why we need it:

Before, there was an apparent typo where the Helm test pod was rendered even when test.enabled=false (the test.enabled value didn't really do anything before). This change fixes that.

Which issue(s) this PR fixes:

Replaces #13180

Fixes #12765

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• Title matches the required conventional commits format, see here
  • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Kubernetes Manifest Diff Summary

Scenario: default-single-binary-values (Added: 0, Modified: 0, Removed: 0)

Summary:

• Added: 0

• Modified: 0

• Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: default-values (Added: 0, Modified: 0, Removed: 0)

Summary:

• Added: 0

• Modified: 0

• Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: ingress-values (Added: 0, Modified: 0, Removed: 1)

Summary:

• Added: 0

• Modified: 0

• Removed: 1

Added Files

No added files

Modified Files

No modified files

Removed Files

loki/templates/tests/test-canary.yaml

---
# Source: loki/templates/tests/test-canary.yaml
apiVersion: v1
kind: Pod
metadata:
 name: "loki-helm-test"
 namespace: default
 labels:
 helm.sh/chart: loki-6.23.0
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name
 app.kubernetes.io/version: "3.3.1"
 app.kubernetes.io/component: helm-test
 annotations:
 "helm.sh/hook": test
spec:
 containers:
 - name: loki-helm-test
 image: docker.io/grafana/loki-helm-test:ewelch-distributed-helm-chart-17db5ee
 env:
 - name: CANARY_SERVICE_ADDRESS
 value: "http://loki-canary:3500/metrics"
 - name: CANARY_PROMETHEUS_ADDRESS
 value: ""
 - name: CANARY_TEST_TIMEOUT
 value: "1m"
 args:
 - -test.v
 restartPolicy: Never

Scenario: legacy-monitoring-values (Added: 0, Modified: 0, Removed: 0)

Summary:

• Added: 0

• Modified: 0

• Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 0, Removed: 0)

Summary:

• Added: 0

• Modified: 0

• Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

[trevorwhitney]

lgtm, thanks!