Skip to content

fix: Disable Helm test pod when test.enabled=false #15346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: Disable Helm test pod when test.enabled=false #15346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d22fa5
fix: Disable Helm test pod when test.enabled=false
lindhe Dec 10, 2024
e0394dd
Merge branch 'main' into lindhe/fix-helm-test
lindhe Dec 10, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Disable Helm test pod when test.enabled=false 
Replaces #13180

Fixes #12765

Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
  • Loading branch information
@lindhe
lindhe committed Dec 10, 2024
commit 5d22fa5a9a46b91d0aaa83765694f2dd4ab9dbef
2 changes: 2 additions & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ Entries should include a reference to the pull request that introduced the chang

[//]: # (<AUTOMATED_UPDATES_LOCATOR> : do not remove this line. This locator is used by the CI pipeline to automatically create a changelog entry for each new Loki release. Add other chart versions and respective changelog entries bellow this line.)

- [BUGFIX] Disables the Helm test pod when `test.enabled=false`.

## 6.23.0

- [CHANGE] Changed version of Grafana Loki to 3.3.1
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/templates/tests/test-canary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- with .Values.test }}
{{- if $.Values.lokiCanary.enabled }}
{{- if (and .enabled $.Values.lokiCanary.enabled) }}
---
apiVersion: v1
kind: Pod
Expand Down
Loading