-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Description
Howdy, I cloned nav2 in a fresh ros:rolling docker image + apt upgrade and ran pre-commit. ament_mypy seems to be failing (error log is much longer but I'll spare you the details); is this expected? How come it's not caught in CI?
I can open a separate issue if it's not expected and actually a bug.
root@ae125719ddf5:~/navigation2# pre-commit run --all
[INFO] Installing environment for https://github.com/python-jsonschema/check-jsonschema.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check python ast.........................................................Passed
check for case conflicts.................................................Passed
check for merge conflicts................................................Passed
check for broken symlinks............................(no files to check)Skipped
check xml................................................................Passed
check yaml...............................................................Passed
debug statements (python)................................................Passed
fix end of files.........................................................Passed
forbid submodules....................................(no files to check)Skipped
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed
fix utf-8 byte order marker..............................................Passed
isort (python)...........................................................Passed
codespell................................................................Passed
Validate GitHub Workflows................................................Passed
Validate GitHub Actions..............................(no files to check)Skipped
Validate Dependabot Config (v2)..........................................Passed
ament_lint_cmake.........................................................Passed
ament_cpplint............................................................Passed
ament_uncrustify.........................................................Passed
ament_xmllint............................................................Passed
ament_flake8.............................................................Passed
ament_pep257.............................................................Passed
ament_mypy...............................................................Failed
hook id: ament_mypy
exit code: 1
mypy error encountered
Warning: unused section(s) in tools/pyproject.toml: module = ['ament_copyright.', 'ament_flake8.', 'ament_pep257.', 'geographic_msgs.', 'geometry_msgs.', 'geopandas.', 'matplotlib.', 'nav2_loopback_sim.', 'nav2_msgs.', 'nav_msgs.', 'pandas.', 'sensor_msgs.', 'std_msgs.', 'std_srvs.', 'tf2_ros.', 'tf_transformations.', 'zmq.']
Regular report continues:
Success: no issues found in 9 source files
mypy error encountered
Warning: unused section(s) in tools/pyproject.toml: module = ['ament_copyright.', 'ament_flake8.', 'ament_pep257.'
@mini-1235 do you use pre-commit locally? If yes, are you able to reproduce?