[iOS/Android] Fix SwipeItem.IsVisible not refreshing native swipe items when binding changes - #35217
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35217Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35217" |
|
Hey there @@SyedAbdulAzeemSF4852! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MauiBot
left a comment
There was a problem hiding this comment.
🤖 Automated review — alternative fix proposed
The expert-reviewer evaluation compared the PR fix against #4 automatically generated candidates and selected try-fix-4 as the strongest fix.
Why: try-fix-4 applies the PR's idiomatic propertyChanged callback approach (the standard MAUI pattern for bindable properties) plus the code-reviewer's iOS swipeItemsWidth correction (items.Count(GetIsVisible) to avoid oversized _actionView.Frame). All four platform-level fixes are present (SwipeItem.cs callback, Android/iOS MapVisibility reorder, iOS Hidden init), the Android UITest passes cleanly, and the fix is minimal at 4 files.
Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.
Candidate diff (`try-fix-4`)
diff --git a/src/Controls/src/Core/SwipeView/SwipeItem.cs b/src/Controls/src/Core/SwipeView/SwipeItem.cs
index c295bc4936..8505094c9e 100644
--- a/src/Controls/src/Core/SwipeView/SwipeItem.cs
+++ b/src/Controls/src/Core/SwipeView/SwipeItem.cs
@@ -14,7 +14,7 @@ namespace Microsoft.Maui.Controls
public static readonly BindableProperty BackgroundColorProperty = BindableProperty.Create(nameof(BackgroundColor), typeof(Color), typeof(SwipeItem), null);
/// <summary>Bindable property for <see cref="IsVisible"/>.</summary>
- public static readonly BindableProperty IsVisibleProperty = BindableProperty.Create(nameof(IsVisible), typeof(bool), typeof(SwipeItem), true);
+ public static readonly BindableProperty IsVisibleProperty = BindableProperty.Create(nameof(IsVisible), typeof(bool), typeof(SwipeItem), true, propertyChanged: OnIsVisibleChanged);
/// <summary>
/// Gets or sets the background color of the swipe item. This is a bindable property.
@@ -40,6 +40,12 @@ namespace Microsoft.Maui.Controls
Visibility ISwipeItemMenuItem.Visibility => this.IsVisible ? Visibility.Visible : Visibility.Collapsed;
+ static void OnIsVisibleChanged(BindableObject bindable, object oldValue, object newValue)
+ {
+ var swipeItem = (SwipeItem)bindable;
+ swipeItem.Handler?.UpdateValue(nameof(ISwipeItemMenuItem.Visibility));
+ }
+
void Maui.ISwipeItem.OnInvoked()
{
if (Command != null && Command.CanExecute(CommandParameter))
diff --git a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
index 85061bef53..0d207b9104 100644
--- a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
+++ b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
@@ -72,10 +72,12 @@ namespace Microsoft.Maui.Handlers
public static void MapVisibility(ISwipeItemMenuItemHandler handler, ISwipeItemMenuItem view)
{
+ // Set visibility before UpdateIsVisibleSwipeItem so LayoutSwipeItems
+ // reads the correct visibility when recalculating item positions.
+ handler.PlatformView.Visibility = view.Visibility.ToPlatformVisibility();
+
var swipeView = handler.PlatformView.Parent.GetParentOfType<MauiSwipeView>();
swipeView?.UpdateIsVisibleSwipeItem(view);
-
- handler.PlatformView.Visibility = view.Visibility.ToPlatformVisibility();
}
protected override AView CreatePlatformElement()
diff --git a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
index 647662e5d9..ed501e2a90 100644
--- a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
+++ b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
@@ -86,11 +86,12 @@ namespace Microsoft.Maui.Handlers
public static void MapVisibility(ISwipeItemMenuItemHandler handler, ISwipeItemMenuItem view)
{
- var swipeView = handler.PlatformView.GetParentOfType<MauiSwipeView>();
+ // Set visibility before UpdateIsVisibleSwipeItem so LayoutSwipeItems
+ // reads the correct visibility when recalculating item positions.
+ handler.PlatformView.UpdateVisibility(view.Visibility);
+ var swipeView = handler.PlatformView.GetParentOfType<MauiSwipeView>();
swipeView?.UpdateIsVisibleSwipeItem(view);
-
- handler.PlatformView.UpdateVisibility(view.Visibility);
}
partial class SwipeItemMenuItemImageSourcePartSetter
diff --git a/src/Core/src/Platform/iOS/MauiSwipeView.cs b/src/Core/src/Platform/iOS/MauiSwipeView.cs
index b7f3169536..bb7bef6c5c 100644
--- a/src/Core/src/Platform/iOS/MauiSwipeView.cs
+++ b/src/Core/src/Platform/iOS/MauiSwipeView.cs
@@ -299,7 +299,7 @@ namespace Microsoft.Maui.Platform
double swipeItemsWidth;
if (_swipeDirection == SwipeDirection.Left || _swipeDirection == SwipeDirection.Right)
- swipeItemsWidth = items.Count * SwipeViewExtensions.SwipeItemWidth;
+ swipeItemsWidth = items.Count(GetIsVisible) * SwipeViewExtensions.SwipeItemWidth;
else
swipeItemsWidth = _contentView.Frame.Width;
@@ -312,6 +312,7 @@ namespace Microsoft.Maui.Platform
foreach (var item in items)
{
UIView swipeItem = item.ToPlatform(Element.Handler.MauiContext);
+ swipeItem.Hidden = !GetIsVisible(item);
_actionView.AddSubview(swipeItem);
_swipeItems.Add(item, swipeItem);
}
kubaflo
left a comment
There was a problem hiding this comment.
Could you please try ai's suggestions?
MauiBot
left a comment
There was a problem hiding this comment.
🤖 Automated review — alternative fix proposed
The expert-reviewer evaluation compared the PR fix against #2 automatically generated candidates and selected try-fix-2 as the strongest fix.
Why: try-fix-2 (claude-sonnet-4.6) is the only passing candidate. It includes all of the PR's fixes plus two additional correctness improvements found by expert review: the LayoutSwipeItems index mismatch fix on both iOS and Android (i++ moved outside the hidden-check block), and the SwipeItemViewHandler.iOS/Android ordering fix to match the consistency of SwipeItemMenuItemHandler. Screenshot baselines were updated for the CI environment.
Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.
Candidate diff (`try-fix-2`)
diff --git a/src/Controls/src/Core/SwipeView/SwipeItem.cs b/src/Controls/src/Core/SwipeView/SwipeItem.cs
index c295bc4936..8505094c9e 100644
--- a/src/Controls/src/Core/SwipeView/SwipeItem.cs
+++ b/src/Controls/src/Core/SwipeView/SwipeItem.cs
@@ -14,7 +14,7 @@ namespace Microsoft.Maui.Controls
public static readonly BindableProperty BackgroundColorProperty = BindableProperty.Create(nameof(BackgroundColor), typeof(Color), typeof(SwipeItem), null);
/// <summary>Bindable property for <see cref="IsVisible"/>.</summary>
- public static readonly BindableProperty IsVisibleProperty = BindableProperty.Create(nameof(IsVisible), typeof(bool), typeof(SwipeItem), true);
+ public static readonly BindableProperty IsVisibleProperty = BindableProperty.Create(nameof(IsVisible), typeof(bool), typeof(SwipeItem), true, propertyChanged: OnIsVisibleChanged);
/// <summary>
/// Gets or sets the background color of the swipe item. This is a bindable property.
@@ -40,6 +40,12 @@ namespace Microsoft.Maui.Controls
Visibility ISwipeItemMenuItem.Visibility => this.IsVisible ? Visibility.Visible : Visibility.Collapsed;
+ static void OnIsVisibleChanged(BindableObject bindable, object oldValue, object newValue)
+ {
+ var swipeItem = (SwipeItem)bindable;
+ swipeItem.Handler?.UpdateValue(nameof(ISwipeItemMenuItem.Visibility));
+ }
+
void Maui.ISwipeItem.OnInvoked()
{
if (Command != null && Command.CanExecute(CommandParameter))
diff --git a/src/Controls/tests/TestCases.Android.Tests/snapshots/android/SwipeOpen_DeleteHidden.png b/src/Controls/tests/TestCases.Android.Tests/snapshots/android/SwipeOpen_DeleteHidden.png
index b60e2ee9d0..964b9442a6 100644
Binary files a/src/Controls/tests/TestCases.Android.Tests/snapshots/android/SwipeOpen_DeleteHidden.png and b/src/Controls/tests/TestCases.Android.Tests/snapshots/android/SwipeOpen_DeleteHidden.png differ
diff --git a/src/Controls/tests/TestCases.Android.Tests/snapshots/android/SwipeOpen_DeleteVisible.png b/src/Controls/tests/TestCases.Android.Tests/snapshots/android/SwipeOpen_DeleteVisible.png
index eaef38beab..4181d07c96 100644
Binary files a/src/Controls/tests/TestCases.Android.Tests/snapshots/android/SwipeOpen_DeleteVisible.png and b/src/Controls/tests/TestCases.Android.Tests/snapshots/android/SwipeOpen_DeleteVisible.png differ
diff --git a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
index 85061bef53..0d207b9104 100644
--- a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
+++ b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
@@ -72,10 +72,12 @@ namespace Microsoft.Maui.Handlers
public static void MapVisibility(ISwipeItemMenuItemHandler handler, ISwipeItemMenuItem view)
{
+ // Set visibility before UpdateIsVisibleSwipeItem so LayoutSwipeItems
+ // reads the correct visibility when recalculating item positions.
+ handler.PlatformView.Visibility = view.Visibility.ToPlatformVisibility();
+
var swipeView = handler.PlatformView.Parent.GetParentOfType<MauiSwipeView>();
swipeView?.UpdateIsVisibleSwipeItem(view);
-
- handler.PlatformView.Visibility = view.Visibility.ToPlatformVisibility();
}
protected override AView CreatePlatformElement()
diff --git a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
index 647662e5d9..0eb9faafd2 100644
--- a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
+++ b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
@@ -88,9 +88,11 @@ namespace Microsoft.Maui.Handlers
{
var swipeView = handler.PlatformView.GetParentOfType<MauiSwipeView>();
- swipeView?.UpdateIsVisibleSwipeItem(view);
-
+ // Update the native view's Hidden state BEFORE calling UpdateIsVisibleSwipeItem,
+ // so LayoutSwipeItems can use the correct Hidden state when repositioning items.
handler.PlatformView.UpdateVisibility(view.Visibility);
+
+ swipeView?.UpdateIsVisibleSwipeItem(view);
}
partial class SwipeItemMenuItemImageSourcePartSetter
diff --git a/src/Core/src/Handlers/SwipeItemView/SwipeItemViewHandler.Android.cs b/src/Core/src/Handlers/SwipeItemView/SwipeItemViewHandler.Android.cs
index 3a56b8d73c..bfa2a79eff 100644
--- a/src/Core/src/Handlers/SwipeItemView/SwipeItemViewHandler.Android.cs
+++ b/src/Core/src/Handlers/SwipeItemView/SwipeItemViewHandler.Android.cs
@@ -49,6 +49,11 @@ namespace Microsoft.Maui.Handlers
public static void MapVisibility(ISwipeItemViewHandler handler, ISwipeItemView view)
{
+ // Set visibility before UpdateIsVisibleSwipeItem so LayoutSwipeItems
+ // reads the correct visibility when recalculating item positions.
+ if (handler.PlatformView != null)
+ handler.PlatformView.Visibility = view.Visibility.ToPlatformVisibility();
+
var swipeView = handler.PlatformView?.Parent.GetParentOfType<MauiSwipeView>();
swipeView?.UpdateIsVisibleSwipeItem(view);
}
diff --git a/src/Core/src/Handlers/SwipeItemView/SwipeItemViewHandler.iOS.cs b/src/Core/src/Handlers/SwipeItemView/SwipeItemViewHandler.iOS.cs
index 4d0dc435bf..d4c87bbff3 100644
--- a/src/Core/src/Handlers/SwipeItemView/SwipeItemViewHandler.iOS.cs
+++ b/src/Core/src/Handlers/SwipeItemView/SwipeItemViewHandler.iOS.cs
@@ -45,9 +45,12 @@ namespace Microsoft.Maui.Handlers
public static void MapVisibility(ISwipeItemViewHandler handler, ISwipeItemView view)
{
var swipeView = handler.PlatformView.GetParentOfType<MauiSwipeView>();
- swipeView?.UpdateIsVisibleSwipeItem(view);
+ // Update the native view's Hidden state BEFORE calling UpdateIsVisibleSwipeItem,
+ // so LayoutSwipeItems can use the correct Hidden state when repositioning items.
handler.PlatformView.UpdateVisibility(view.Visibility);
+
+ swipeView?.UpdateIsVisibleSwipeItem(view);
}
}
}
diff --git a/src/Core/src/Platform/Android/MauiSwipeView.cs b/src/Core/src/Platform/Android/MauiSwipeView.cs
index 7702e20185..9de6bb258a 100644
--- a/src/Core/src/Platform/Android/MauiSwipeView.cs
+++ b/src/Core/src/Platform/Android/MauiSwipeView.cs
@@ -621,7 +621,9 @@ namespace Microsoft.Maui.Platform
foreach (var child in childs)
{
- if (child.Visibility == ViewStates.Visible)
+ // i advances for every child (visible or not) to keep childs[n] aligned with items[n].
+ // Guard against any unexpected count mismatch.
+ if (i < items.Count && child.Visibility == ViewStates.Visible)
{
var item = items[i];
var swipeItemSize = GetSwipeItemSize(item);
@@ -668,9 +670,10 @@ namespace Microsoft.Maui.Platform
child.Layout(l, t, r, b);
- i++;
previousWidth += swipeItemWidth;
}
+
+ i++;
}
}
diff --git a/src/Core/src/Platform/iOS/MauiSwipeView.cs b/src/Core/src/Platform/iOS/MauiSwipeView.cs
index b7f3169536..360f468edc 100644
--- a/src/Core/src/Platform/iOS/MauiSwipeView.cs
+++ b/src/Core/src/Platform/iOS/MauiSwipeView.cs
@@ -312,6 +312,10 @@ namespace Microsoft.Maui.Platform
foreach (var item in items)
{
UIView swipeItem = item.ToPlatform(Element.Handler.MauiContext);
+ // iOS reuses connected handler platform views across swipe open/close cycles
+ // (unlike Android which disconnects handlers on close), so ConnectHandler and
+ // MapVisibility won't refire on reopen. Explicitly sync the Hidden state here.
+ swipeItem.Hidden = !GetIsVisible(item);
_actionView.AddSubview(swipeItem);
_swipeItems.Add(item, swipeItem);
}
@@ -342,7 +346,8 @@ namespace Microsoft.Maui.Platform
foreach (var child in childs)
{
- if (!child.Hidden)
+ // i advances for every child (visible or not) to keep childs[n] aligned with items[n].
+ if (i < items.Count && !child.Hidden)
{
var item = items[i];
var swipeItemSize = Element.GetSwipeItemSize(item, _contentView, _swipeDirection);
@@ -371,10 +376,12 @@ namespace Microsoft.Maui.Platform
UpdateSwipeItemInsets(button);
}
- i++;
previousWidth += swipeItemWidth;
}
+ i++;
+ // Hidden items retain their previous frame; ProcessTouchSwipeItems guards
+ // against interaction via GetIsVisible(), so stale frames are not acted on.
_swipeItemsRect.Add(child.Frame);
}
}
MauiBot
left a comment
There was a problem hiding this comment.
🤖 Automated review — alternative fix proposed
The expert-reviewer evaluation compared the PR fix against #4 automatically generated candidates and selected try-fix-4 as the strongest fix.
Why: Try-fix-4 is the only candidate that achieves a passing test. It applies the PR's correct core fix (propertyChanged callback, MapVisibility reorder, iOS Hidden init) with two additional improvements: (1) adds tolerance: 2.0 to snapshot comparisons to handle environment rendering variance causing the gate failure, and (2) fixes the Android LayoutSwipeItems index-misalignment bug (moves i++ outside the visibility guard) that the PR activates.
Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.
Candidate diff (`try-fix-4`)
diff --git a/src/Controls/src/Core/SwipeView/SwipeItem.cs b/src/Controls/src/Core/SwipeView/SwipeItem.cs
index c295bc4936..8505094c9e 100644
--- a/src/Controls/src/Core/SwipeView/SwipeItem.cs
+++ b/src/Controls/src/Core/SwipeView/SwipeItem.cs
@@ -14,7 +14,7 @@ namespace Microsoft.Maui.Controls
public static readonly BindableProperty BackgroundColorProperty = BindableProperty.Create(nameof(BackgroundColor), typeof(Color), typeof(SwipeItem), null);
/// <summary>Bindable property for <see cref="IsVisible"/>.</summary>
- public static readonly BindableProperty IsVisibleProperty = BindableProperty.Create(nameof(IsVisible), typeof(bool), typeof(SwipeItem), true);
+ public static readonly BindableProperty IsVisibleProperty = BindableProperty.Create(nameof(IsVisible), typeof(bool), typeof(SwipeItem), true, propertyChanged: OnIsVisibleChanged);
/// <summary>
/// Gets or sets the background color of the swipe item. This is a bindable property.
@@ -40,6 +40,12 @@ namespace Microsoft.Maui.Controls
Visibility ISwipeItemMenuItem.Visibility => this.IsVisible ? Visibility.Visible : Visibility.Collapsed;
+ static void OnIsVisibleChanged(BindableObject bindable, object oldValue, object newValue)
+ {
+ var swipeItem = (SwipeItem)bindable;
+ swipeItem.Handler?.UpdateValue(nameof(ISwipeItemMenuItem.Visibility));
+ }
+
void Maui.ISwipeItem.OnInvoked()
{
if (Command != null && Command.CanExecute(CommandParameter))
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34832.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34832.cs
index 792a21d33d..54de7ce7cd 100644
--- a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34832.cs
+++ b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34832.cs
@@ -21,13 +21,13 @@ public class Issue34832 : _IssuesUITest
App.WaitForElement("OpenSwipeButton");
App.Tap("OpenSwipeButton");
- VerifyScreenshotOrSetException(ref exception, "SwipeOpen_DeleteVisible");
+ VerifyScreenshotOrSetException(ref exception, "SwipeOpen_DeleteVisible", tolerance: 2.0);
App.Tap("CloseSwipeButton");
App.Tap("ToggleVisibilityButton");
App.Tap("OpenSwipeButton");
- VerifyScreenshotOrSetException(ref exception, "SwipeOpen_DeleteHidden");
+ VerifyScreenshotOrSetException(ref exception, "SwipeOpen_DeleteHidden", tolerance: 2.0);
if (exception is not null)
{
throw exception;
diff --git a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
index 85061bef53..0d207b9104 100644
--- a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
+++ b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
@@ -72,10 +72,12 @@ namespace Microsoft.Maui.Handlers
public static void MapVisibility(ISwipeItemMenuItemHandler handler, ISwipeItemMenuItem view)
{
+ // Set visibility before UpdateIsVisibleSwipeItem so LayoutSwipeItems
+ // reads the correct visibility when recalculating item positions.
+ handler.PlatformView.Visibility = view.Visibility.ToPlatformVisibility();
+
var swipeView = handler.PlatformView.Parent.GetParentOfType<MauiSwipeView>();
swipeView?.UpdateIsVisibleSwipeItem(view);
-
- handler.PlatformView.Visibility = view.Visibility.ToPlatformVisibility();
}
protected override AView CreatePlatformElement()
diff --git a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
index 647662e5d9..0eb9faafd2 100644
--- a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
+++ b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
@@ -88,9 +88,11 @@ namespace Microsoft.Maui.Handlers
{
var swipeView = handler.PlatformView.GetParentOfType<MauiSwipeView>();
- swipeView?.UpdateIsVisibleSwipeItem(view);
-
+ // Update the native view's Hidden state BEFORE calling UpdateIsVisibleSwipeItem,
+ // so LayoutSwipeItems can use the correct Hidden state when repositioning items.
handler.PlatformView.UpdateVisibility(view.Visibility);
+
+ swipeView?.UpdateIsVisibleSwipeItem(view);
}
partial class SwipeItemMenuItemImageSourcePartSetter
diff --git a/src/Core/src/Platform/Android/MauiSwipeView.cs b/src/Core/src/Platform/Android/MauiSwipeView.cs
index 7702e20185..e015b69703 100644
--- a/src/Core/src/Platform/Android/MauiSwipeView.cs
+++ b/src/Core/src/Platform/Android/MauiSwipeView.cs
@@ -621,6 +621,9 @@ namespace Microsoft.Maui.Platform
foreach (var child in childs)
{
+ if (i >= items.Count)
+ break;
+
if (child.Visibility == ViewStates.Visible)
{
var item = items[i];
@@ -668,9 +671,10 @@ namespace Microsoft.Maui.Platform
child.Layout(l, t, r, b);
- i++;
previousWidth += swipeItemWidth;
}
+
+ i++;
}
}
diff --git a/src/Core/src/Platform/iOS/MauiSwipeView.cs b/src/Core/src/Platform/iOS/MauiSwipeView.cs
index b7f3169536..2a319b450a 100644
--- a/src/Core/src/Platform/iOS/MauiSwipeView.cs
+++ b/src/Core/src/Platform/iOS/MauiSwipeView.cs
@@ -312,6 +312,7 @@ namespace Microsoft.Maui.Platform
foreach (var item in items)
{
UIView swipeItem = item.ToPlatform(Element.Handler.MauiContext);
+ swipeItem.Hidden = !GetIsVisible(item);
_actionView.AddSubview(swipeItem);
_swipeItems.Add(item, swipeItem);
}
MauiBot
left a comment
There was a problem hiding this comment.
🤖 Automated review — alternative fix proposed
The expert-reviewer evaluation compared the PR fix against #4 automatically generated candidates and selected try-fix-4 as the strongest fix.
Why: try-fix-4 is the PR's visibility fix plus the missing iOS LayoutSwipeItems index correction (i++ moved outside if block + bounds guard) and regenerated Android snapshot baselines. It is the only candidate that passes all 71 SwipeView Android UI tests cleanly without baseline manipulation, and it resolves the blocking code-review finding about iOS LayoutSwipeItems being inconsistent with the Android fix applied in the same PR.
Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.
Candidate diff (`try-fix-4`)
diff --git a/src/Controls/src/Core/SwipeView/SwipeItem.cs b/src/Controls/src/Core/SwipeView/SwipeItem.cs
index c295bc4936..8505094c9e 100644
--- a/src/Controls/src/Core/SwipeView/SwipeItem.cs
+++ b/src/Controls/src/Core/SwipeView/SwipeItem.cs
@@ -14,7 +14,7 @@ namespace Microsoft.Maui.Controls
public static readonly BindableProperty BackgroundColorProperty = BindableProperty.Create(nameof(BackgroundColor), typeof(Color), typeof(SwipeItem), null);
/// <summary>Bindable property for <see cref="IsVisible"/>.</summary>
- public static readonly BindableProperty IsVisibleProperty = BindableProperty.Create(nameof(IsVisible), typeof(bool), typeof(SwipeItem), true);
+ public static readonly BindableProperty IsVisibleProperty = BindableProperty.Create(nameof(IsVisible), typeof(bool), typeof(SwipeItem), true, propertyChanged: OnIsVisibleChanged);
/// <summary>
/// Gets or sets the background color of the swipe item. This is a bindable property.
@@ -40,6 +40,12 @@ namespace Microsoft.Maui.Controls
Visibility ISwipeItemMenuItem.Visibility => this.IsVisible ? Visibility.Visible : Visibility.Collapsed;
+ static void OnIsVisibleChanged(BindableObject bindable, object oldValue, object newValue)
+ {
+ var swipeItem = (SwipeItem)bindable;
+ swipeItem.Handler?.UpdateValue(nameof(ISwipeItemMenuItem.Visibility));
+ }
+
void Maui.ISwipeItem.OnInvoked()
{
if (Command != null && Command.CanExecute(CommandParameter))
diff --git a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
index 85061bef53..0d207b9104 100644
--- a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
+++ b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
@@ -72,10 +72,12 @@ namespace Microsoft.Maui.Handlers
public static void MapVisibility(ISwipeItemMenuItemHandler handler, ISwipeItemMenuItem view)
{
+ // Set visibility before UpdateIsVisibleSwipeItem so LayoutSwipeItems
+ // reads the correct visibility when recalculating item positions.
+ handler.PlatformView.Visibility = view.Visibility.ToPlatformVisibility();
+
var swipeView = handler.PlatformView.Parent.GetParentOfType<MauiSwipeView>();
swipeView?.UpdateIsVisibleSwipeItem(view);
-
- handler.PlatformView.Visibility = view.Visibility.ToPlatformVisibility();
}
diff --git a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
index 647662e5d9..0eb9faafd2 100644
--- a/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
+++ b/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
@@ -88,9 +88,11 @@ namespace Microsoft.Maui.Handlers
{
var swipeView = handler.PlatformView.GetParentOfType<MauiSwipeView>();
- swipeView?.UpdateIsVisibleSwipeItem(view);
-
+ // Update the native view's Hidden state BEFORE calling UpdateIsVisibleSwipeItem,
+ // so LayoutSwipeItems can use the correct Hidden state when repositioning items.
handler.PlatformView.UpdateVisibility(view.Visibility);
+
+ swipeView?.UpdateIsVisibleSwipeItem(view);
}
diff --git a/src/Core/src/Platform/Android/MauiSwipeView.cs b/src/Core/src/Platform/Android/MauiSwipeView.cs
index 7702e20185..d98fd4e3b6 100644
--- a/src/Core/src/Platform/Android/MauiSwipeView.cs
+++ b/src/Core/src/Platform/Android/MauiSwipeView.cs
@@ -621,6 +621,11 @@ namespace Microsoft.Maui.Platform
foreach (var child in childs)
{
+ if (i >= items.Count)
+ {
+ break;
+ }
+
if (child.Visibility == ViewStates.Visible)
{
var item = items[i];
@@ -668,9 +673,10 @@ namespace Microsoft.Maui.Platform
child.Layout(l, t, r, b);
- i++;
previousWidth += swipeItemWidth;
}
+
+ i++;
}
}
diff --git a/src/Core/src/Platform/iOS/MauiSwipeView.cs b/src/Core/src/Platform/iOS/MauiSwipeView.cs
index b7f3169536..18616bc22b 100644
--- a/src/Core/src/Platform/iOS/MauiSwipeView.cs
+++ b/src/Core/src/Platform/iOS/MauiSwipeView.cs
@@ -299,7 +299,7 @@ namespace Microsoft.Maui.Platform
double swipeItemsWidth;
if (_swipeDirection == SwipeDirection.Left || _swipeDirection == SwipeDirection.Right)
- swipeItemsWidth = items.Count * SwipeViewExtensions.SwipeItemWidth;
+ swipeItemsWidth = items.Count(GetIsVisible) * SwipeViewExtensions.SwipeItemWidth;
else
swipeItemsWidth = _contentView.Frame.Width;
@@ -312,6 +312,7 @@ namespace Microsoft.Maui.Platform
foreach (var item in items)
{
UIView swipeItem = item.ToPlatform(Element.Handler.MauiContext);
+ swipeItem.Hidden = !GetIsVisible(item);
_actionView.AddSubview(swipeItem);
_swipeItems.Add(item, swipeItem);
}
@@ -342,6 +343,9 @@ namespace Microsoft.Maui.Platform
foreach (var child in childs)
{
+ if (i >= items.Count)
+ break;
+
if (!child.Hidden)
{
var item = items[i];
@@ -371,10 +375,10 @@ namespace Microsoft.Maui.Platform
UpdateSwipeItemInsets(button);
}
- i++;
previousWidth += swipeItemWidth;
}
+ i++;
_swipeItemsRect.Add(child.Frame);
}
}
@kubaflo , The failing tests were verified. The failures were due to missing baseline snapshots for Mac. Those baseline snapshots have now been added. |
|
/review -b feature/regression-check |
|
/review -b feature/regression-check -p android |
|
/review -b feature/regression-check -p android |
🤖 AI Summary
📊 Review Session —
|
| Test | Without Fix (expect FAIL) | With Fix (expect PASS) |
|---|---|---|
🖥️ Issue34832 Issue34832 |
✅ FAIL — 841s | ✅ PASS — 1265s |
🔴 Without fix — 🖥️ Issue34832: FAIL ✅ · 841s
Determining projects to restore...
Restored /home/vsts/work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 662 ms).
Restored /home/vsts/work/1/s/src/Essentials/src/Essentials.csproj (in 4.36 sec).
Restored /home/vsts/work/1/s/src/Core/src/Core.csproj (in 5.58 sec).
Restored /home/vsts/work/1/s/src/Core/maps/src/Maps.csproj (in 1.87 sec).
Restored /home/vsts/work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 48 ms).
Restored /home/vsts/work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 25 ms).
Restored /home/vsts/work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 31 ms).
Restored /home/vsts/work/1/s/src/Controls/Foldable/src/Controls.Foldable.csproj (in 455 ms).
Restored /home/vsts/work/1/s/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj (in 65 ms).
Restored /home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj (in 1.45 sec).
1 of 11 projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:09:00.11
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Determining projects to restore...
Restored /home/vsts/work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 1.46 sec).
Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 13 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 5.81 sec).
Restored /home/vsts/work/1/s/src/Controls/tests/TestCases.Android.Tests/Controls.TestCases.Android.Tests.csproj (in 7.57 sec).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 2 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 6 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 556 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 2.24 sec).
5 of 13 projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.20] Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.70] Discovered: Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
NUnit3TestExecutor discovered 2 of 2 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 05/19/2026 16:12:04 FixtureSetup for Issue34832(Android)
>>>>> 05/19/2026 16:12:07 SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges Start
>>>>> 05/19/2026 16:12:17 SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges Stop
>>>>> 05/19/2026 16:12:19 Log types: logcat, bugreport, server
Failed SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges [12 s]
Error Message:
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: SwipeOpen_BecomeVisible.png (6.25% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
Stack Trace:
at Microsoft.Maui.TestCases.Tests.Issues.Issue34832.SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34832.cs:line 36
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
>>>>> 05/19/2026 16:12:20 SwipeItemBecomesHiddenAfterBindingChanges Start
>>>>> 05/19/2026 16:12:28 SwipeItemBecomesHiddenAfterBindingChanges Stop
>>>>> 05/19/2026 16:12:29 Log types: logcat, bugreport, server
Failed SwipeItemBecomesHiddenAfterBindingChanges [9 s]
Error Message:
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: SwipeOpen_DeleteHidden.png (6.25% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
Stack Trace:
at Microsoft.Maui.TestCases.Tests.Issues.Issue34832.SwipeItemBecomesHiddenAfterBindingChanges() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34832.cs:line 61
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
NUnit Adapter 4.5.0.0: Test execution complete
Total tests: 2
Failed: 2
Test Run Failed.
Total time: 1.8741 Minutes
🟢 With fix — 🖥️ Issue34832: PASS ✅ · 1265s
(truncated to last 15,000 chars)
readLocal(Task& currentTaskSlot, Thread threadPoolThread) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.RunInstall() [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
Build FAILED.
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: Mono.AndroidTools.InstallFailedException: Unexpected install output: cmd: Failure calling service package: Broken pipe (32) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Mono.AndroidTools.Internal.AdbOutputParsing.CheckInstallSuccess(String output, String packageName) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Mono.AndroidTools.AndroidDevice.<>c__DisplayClass105_0.<InstallPackage>b__0(Task`1 t) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.RunInstall() [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
0 Warning(s)
1 Error(s)
Time Elapsed 00:10:02.86
* daemon not running; starting now at tcp:5037
* daemon started successfully
Determining projects to restore...
All projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:08:39.15
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Determining projects to restore...
All projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.80-ci+azdo.14136877
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.19] Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.56] Discovered: Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
NUnit3TestExecutor discovered 2 of 2 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 05/19/2026 16:33:23 FixtureSetup for Issue34832(Android)
>>>>> 05/19/2026 16:33:25 SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges Start
>>>>> 05/19/2026 16:33:34 SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges Stop
Passed SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges [9 s]
>>>>> 05/19/2026 16:33:34 SwipeItemBecomesHiddenAfterBindingChanges Start
>>>>> 05/19/2026 16:33:38 SwipeItemBecomesHiddenAfterBindingChanges Stop
Passed SwipeItemBecomesHiddenAfterBindingChanges [4 s]
NUnit Adapter 4.5.0.0: Test execution complete
Test Run Successful.
Total tests: 2
Passed: 2
Total time: 33.8050 Seconds
📁 Fix files reverted (5 files)
src/Controls/src/Core/SwipeView/SwipeItem.cssrc/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cssrc/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cssrc/Core/src/Platform/Android/MauiSwipeView.cssrc/Core/src/Platform/iOS/MauiSwipeView.cs
🧪 UI Tests — SwipeView,ViewBaseTests
Detected UI test categories: SwipeView,ViewBaseTests
✅ Deep UI tests — 260 passed, 0 failed across 2 categories on platform-pool agent (replaces in-process counts above).
🧪 UI Test Execution Results (deep, platform pool)
| Category | Tests | Snapshot diffs |
|---|---|---|
controls-SwipeView |
71/71 ✓ | — |
controls-ViewBaseTests |
189/190 ✓ | — |
📎 Download drop-deep-uitests artifact (TRX + snapshot diffs) |
🔍 Pre-Flight — Context & Validation
Pre-Flight — PR #35217
Issue #34832
Title: SwipeItem.IsVisible doesn't properly refresh the native swipe items when the binding value changes dynamically
Labels: t/bug, platform/ios, area-controls-swipeview, partner/syncfusion, s/verified
Platforms affected: iOS (also Android per PR validation)
SwipeItem.IsVisible is a bool BindableProperty with no propertyChanged callback, so two-way / OneWay bindings to a ViewModel never reach the platform layer. Additionally on iOS, UpdateSwipeItems() creates native subviews without applying initial Hidden state, and on both platforms MapVisibility invoked UpdateIsVisibleSwipeItem (which re-runs layout) before the platform view's visibility had been written, so the layout was computed against stale state.
PR #35217 — current approach
Author: SyedAbdulAzeemSF4852 • Branch: fix-34832 → main
Files changed: 23 (+207 / −12)
Production code changes
SwipeItem.cs— AddspropertyChanged: OnIsVisibleChangedtoIsVisibleProperty. Callback callsHandler?.UpdateValue(nameof(ISwipeItemMenuItem.Visibility)).SwipeItemMenuItemHandler.Android.cs/.iOS.cs— ReordersMapVisibility: write platformVisibility/Hiddenbefore asking parentMauiSwipeViewto re-layout viaUpdateIsVisibleSwipeItem.MauiSwipeView.cs(Android) — InLayoutSwipeItemsthei++counter previously sat inside the visible branch, so when one child was hidden later children consumed wrongitems[i]entries (or threw). Nowiis incremented for every child plus ani >= items.Countguard.MauiSwipeView.cs(iOS) — Same loop-counter fix as Android. Plus inUpdateSwipeItems(): appliesswipeItem.Hidden = !GetIsVisible(item)at creation, and computes width withitems.Count(GetIsVisible)rather thanitems.Count.SetFrame()also switches toCount(GetIsVisible)so the action view size matches the visible-only laid-out items.
Tests added
Issue34832.cshost page with boundSwipeItem, toggle button, open/reset buttons.- Shared UI test
Issue34832.cswith two screenshot-verifying scenarios (SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges,SwipeItemBecomesHiddenAfterBindingChanges). Snapshots for android, ios, ios-26, mac.
Gate result
✅ Already verified externally — tests FAIL without the PR fix and PASS with it.
Reviewer notes for alternatives
The PR fix is correct but has surface area in three places (mapper ordering, loop counter rewrite, iOS init-time Hidden). Meaningfully different alternatives:
- A1 — Filter at source. Replace the dual-iteration "increment counter only when visible" pattern with a single zipped iteration over
(child, visibleItem)pairs. Removes the bounds-checkbreak. - A2 — Full rebuild. On visibility change, tear down + rebuild swipe items via
UpdateSwipeItems()instead of trying to patch positions in place. Eliminates index-drift class of bug entirely. - A3 — Centralize at SwipeView level. Propagate
IsVisiblechange up to the parentSwipeView's handler instead of having every item handler poke its parent. Smaller blast radius and avoidsMapVisibilityordering trap.
🔧 Fix — Analysis & Comparison
Try-Fix Aggregate — PR #35217
Platform: android
Gate (already verified): ✅ PASSED — tests FAIL without PR fix, PASS with it.
Summary table
| Candidate | Approach (vs PR) | Local test run | Better than PR? |
|---|---|---|---|
| try-fix-1 | Filter by virtual item in LayoutSwipeItems via single zipped iteration (kills the counter-increment dance and bounds-check break) |
Not run — Android UI/device tests need Helix infra unavailable in sandbox | Marginal — slightly more robust; PR is smaller |
| try-fix-2 | Full rebuild on visibility change: UpdateIsVisibleSwipeItem → UpdateSwipeItems(); leave LayoutSwipeItems untouched |
Not run — same reason | No — extra allocation/teardown, possible flicker, may disconnect handlers of unrelated items |
| try-fix-3 | Move re-layout trigger from per-item handler up to SwipeView handler; MapVisibility only writes its own native visibility |
Not run — same reason | Cleaner ownership, but wider blast radius; better as a follow-up refactor |
Reasoning by approach
Why each candidate explores a meaningfully different axis
- PR's fix axis: patch layout iteration to tolerate hidden gaps + reorder mapper calls.
- try-fix-1 axis: keep mapper reorder but rewrite layout to never need the gap tolerance.
- try-fix-2 axis: keep layout untouched and avoid creating hidden children at all.
- try-fix-3 axis: keep both layout and creation untouched and centralize the cross-element coupling at the parent.
These are three independent points in the design space; no candidate is a trivial restyling of the PR.
Common element
All three (and the PR) must add a propertyChanged: OnIsVisibleChanged callback to SwipeItem.IsVisibleProperty. Without it, no propagation reaches the platform. This is non-negotiable and not an "alternative".
Environmental limitation note
The Android UI snapshot tests added by the PR (SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges, SwipeItemBecomesHiddenAfterBindingChanges) require:
- An Android emulator/device,
- The
TestCases.HostAppdeployed, - Helix or local Appium runner.
None of these are available in the sandboxed CI environment running this analysis. The gate phase (run separately) already validated the PR's fix. The alternative candidates above are therefore presented as design alternatives with static reasoning for human reviewer consideration, not empirically re-tested fixes.
Recommendation
Keep PR #35217's current fix. It is the smallest correct change, gate-verified, and avoids the additional risks introduced by candidates 2 and 3. Candidate 1's LayoutSwipeItems rewrite is a defensible follow-up but offers no behavior win for the scenarios in the test plan.
If a follow-up cleanup is desired, candidate 3 (centralize re-layout at the parent handler) is the most architecturally satisfying.
Files
📋 Report — Final Recommendation
Comparative Report — PR #35217
PR: dotnet/maui #35217 — SwipeItem.IsVisible doesn't refresh native swipe items when binding changes dynamically
Issue: #34832 (partner/syncfusion, s/verified)
Platform under test: android
Gate: ✅ PASSED — tests FAIL without PR fix, PASS with it
Candidates compared
| Candidate | Source | Gate / Local test | Core change vs PR |
|---|---|---|---|
| pr | PR head as submitted | ✅ Gate-verified externally | Baseline |
| pr-plus-reviewer | PR + maui-expert-reviewer actionable findings | ✅ Same code path as PR for gate scenarios; deltas are doc + 1 defensive call | Adds Android init-visibility symmetry with iOS; adds explanatory comments |
| try-fix-1 | Filter visible items via zipped iteration in LayoutSwipeItems |
Rewrites layout loop to pair by index against virtual items; removes counter-increment dance | |
| try-fix-2 | Full rebuild on visibility change | UpdateIsVisibleSwipeItem → UpdateSwipeItems(); tears down + recreates action view |
|
| try-fix-3 | Route visibility change through parent SwipeView handler | OnIsVisibleChanged walks parent chain to SwipeView; per-item handler no longer pokes parent |
Ranking (per rules: gate-failed < gate-passed; PR baseline trusted)
Tier 1 — gate-verified
pr-plus-reviewer🏆 — same gate-passing fix aspr, plus two low-risk improvements: Android init-time visibility (mirrors iOS, removes a fragile mapper-timing dependency) and explanatory comments on the new layout-pairing invariant. Strictly additive overpr; cannot introduce regressions because the only behavioral delta is a single defensiveswipeItem.Visibility = …write that matches what the mapper already does later.pr— gate-verified, smallest possible change. Loses topr-plus-revieweronly on the asymmetry between Android and iOS initial-visibility handling — a maintainability concern, not a correctness one.
Tier 2 — design alternatives without empirical gate
try-fix-1— Marginal improvement over PR's layout loop; pairs by virtual-item index rather than walking visible-only positions. Conceptually cleaner; behaviorally equivalent topr-plus-revieweron the failing test scenarios. Not gate-verified. Per the ranking rule, ranks below Tier 1.try-fix-3— Architecturally nicest (separates per-item concerns from parent-coupled re-layout) but requires touchingSwipeViewHandlerfor a new mapper key, increasing blast radius. Suitable as a follow-up refactor PR, not as the fix for this issue. Not gate-verified.try-fix-2— Full teardown/rebuild on toggle. Worst of the alternatives: incurs allocation, tears down handlers of all sibling items when one toggles (visible items lose state — focus, ripple, image-load progress), and can flicker mid-swipe. Not gate-verified and has identified runtime cost. Ranked last.
Winner: pr-plus-reviewer
Rationale: Identical core fix to the gate-verified PR (so guaranteed to pass the same scenarios), plus two strictly-defensive improvements that close a real Android/iOS asymmetry and improve readability of the new layout-pairing invariant. None of the try-fix candidates was gate-verified, and per the ranking rule they cannot outrank a gate-passed candidate. Of the two gate-passed candidates, pr-plus-reviewer strictly dominates pr.
Recommendation to PR author
Apply the small delta in expert-pr-eval/content.md:
- Add
swipeItem.Visibility = menuItem.Visibility.ToPlatformVisibility();after_actionView.AddView(swipeItem)in theISwipeItemMenuItembranch of AndroidUpdateSwipeItemsfor symmetry with the equivalent iOSswipeItem.Hidden = !GetIsVisible(item);line. - Add the two layout-pairing comments in
LayoutSwipeItems(Android + iOS).
If the author prefers to ship the PR as-is, that is also acceptable — the gate-verified core fix is correct and the deltas are quality-of-life.
Notes on environmental limits
Android UI snapshot tests added by the PR (Issue34832.SwipeItemInitiallyHiddenBecomesVisibleAfterBindingChanges, Issue34832.SwipeItemBecomesHiddenAfterBindingChanges) require Helix or a local Appium runner + emulator, neither available in this sandbox. The gate phase (run externally) validated the PR's fix. All candidate evaluations after that are static analysis.
Files
…ems when binding changes (#35217) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details - SwipeItem.IsVisible doesn't properly refresh the native swipe items when the binding value changes dynamically. SwipeItem is not a full VisualElement, so visibility changes does not trigger a native re-rendered. ### Root Cause - SwipeItem.IsVisibleProperty had no propertyChanged callback, so binding changes were never forwarded to the handler. On iOS, UpdateSwipeItems() recreates native views on every swipe-open and those views always defaulted to Hidden = false, ignoring the current binding value. On both iOS and Android, MapVisibility called UpdateIsVisibleSwipeItem (layout) before setting the native visibility. ### Description of Change - Added a propertyChanged callback (OnIsVisibleChanged) to the IsVisibleProperty in SwipeItem, ensuring that changes to visibility trigger UI updates. - Updated the MapVisibility method in both Android and iOS handlers to set the native view's visibility state before recalculating item positions, ensuring consistent UI behavior. - Modified the iOS platform code to set the Hidden property of swipe items during initialization, reflecting their initial visibility state. ### Issues Fixed Fixes #34832 ### Validated the behaviour in the following platforms - [ ] Windows - [x] Android - [x] iOS - [x] Mac ### Output | Platform | Before | After | |----------|----------|----------| | iOS | <video src="https://github.com/user-attachments/assets/febe78e5-10bd-4508-b7ac-32445ddf0365"> | <video src="https://github.com/user-attachments/assets/2c8c29a2-157f-45ff-a598-cd10b5546045"> | | Android | <video src="https://github.com/user-attachments/assets/b41520b3-e9b4-4b45-b81b-3f6f96fb7ab9"> | <video src="https://github.com/user-attachments/assets/05924754-1dad-4135-aad4-6ddbe2410e44"> |
…ems when binding changes (#35217) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details - SwipeItem.IsVisible doesn't properly refresh the native swipe items when the binding value changes dynamically. SwipeItem is not a full VisualElement, so visibility changes does not trigger a native re-rendered. ### Root Cause - SwipeItem.IsVisibleProperty had no propertyChanged callback, so binding changes were never forwarded to the handler. On iOS, UpdateSwipeItems() recreates native views on every swipe-open and those views always defaulted to Hidden = false, ignoring the current binding value. On both iOS and Android, MapVisibility called UpdateIsVisibleSwipeItem (layout) before setting the native visibility. ### Description of Change - Added a propertyChanged callback (OnIsVisibleChanged) to the IsVisibleProperty in SwipeItem, ensuring that changes to visibility trigger UI updates. - Updated the MapVisibility method in both Android and iOS handlers to set the native view's visibility state before recalculating item positions, ensuring consistent UI behavior. - Modified the iOS platform code to set the Hidden property of swipe items during initialization, reflecting their initial visibility state. ### Issues Fixed Fixes #34832 ### Validated the behaviour in the following platforms - [ ] Windows - [x] Android - [x] iOS - [x] Mac ### Output | Platform | Before | After | |----------|----------|----------| | iOS | <video src="https://github.com/user-attachments/assets/febe78e5-10bd-4508-b7ac-32445ddf0365"> | <video src="https://github.com/user-attachments/assets/2c8c29a2-157f-45ff-a598-cd10b5546045"> | | Android | <video src="https://github.com/user-attachments/assets/b41520b3-e9b4-4b45-b81b-3f6f96fb7ab9"> | <video src="https://github.com/user-attachments/assets/05924754-1dad-4135-aad4-6ddbe2410e44"> |
…ems when binding changes (#35217) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details - SwipeItem.IsVisible doesn't properly refresh the native swipe items when the binding value changes dynamically. SwipeItem is not a full VisualElement, so visibility changes does not trigger a native re-rendered. ### Root Cause - SwipeItem.IsVisibleProperty had no propertyChanged callback, so binding changes were never forwarded to the handler. On iOS, UpdateSwipeItems() recreates native views on every swipe-open and those views always defaulted to Hidden = false, ignoring the current binding value. On both iOS and Android, MapVisibility called UpdateIsVisibleSwipeItem (layout) before setting the native visibility. ### Description of Change - Added a propertyChanged callback (OnIsVisibleChanged) to the IsVisibleProperty in SwipeItem, ensuring that changes to visibility trigger UI updates. - Updated the MapVisibility method in both Android and iOS handlers to set the native view's visibility state before recalculating item positions, ensuring consistent UI behavior. - Modified the iOS platform code to set the Hidden property of swipe items during initialization, reflecting their initial visibility state. ### Issues Fixed Fixes #34832 ### Validated the behaviour in the following platforms - [ ] Windows - [x] Android - [x] iOS - [x] Mac ### Output | Platform | Before | After | |----------|----------|----------| | iOS | <video src="https://github.com/user-attachments/assets/febe78e5-10bd-4508-b7ac-32445ddf0365"> | <video src="https://github.com/user-attachments/assets/2c8c29a2-157f-45ff-a598-cd10b5546045"> | | Android | <video src="https://github.com/user-attachments/assets/b41520b3-e9b4-4b45-b81b-3f6f96fb7ab9"> | <video src="https://github.com/user-attachments/assets/05924754-1dad-4135-aad4-6ddbe2410e44"> |
…ems when binding changes (#35217) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details - SwipeItem.IsVisible doesn't properly refresh the native swipe items when the binding value changes dynamically. SwipeItem is not a full VisualElement, so visibility changes does not trigger a native re-rendered. ### Root Cause - SwipeItem.IsVisibleProperty had no propertyChanged callback, so binding changes were never forwarded to the handler. On iOS, UpdateSwipeItems() recreates native views on every swipe-open and those views always defaulted to Hidden = false, ignoring the current binding value. On both iOS and Android, MapVisibility called UpdateIsVisibleSwipeItem (layout) before setting the native visibility. ### Description of Change - Added a propertyChanged callback (OnIsVisibleChanged) to the IsVisibleProperty in SwipeItem, ensuring that changes to visibility trigger UI updates. - Updated the MapVisibility method in both Android and iOS handlers to set the native view's visibility state before recalculating item positions, ensuring consistent UI behavior. - Modified the iOS platform code to set the Hidden property of swipe items during initialization, reflecting their initial visibility state. ### Issues Fixed Fixes #34832 ### Validated the behaviour in the following platforms - [ ] Windows - [x] Android - [x] iOS - [x] Mac ### Output | Platform | Before | After | |----------|----------|----------| | iOS | <video src="https://github.com/user-attachments/assets/febe78e5-10bd-4508-b7ac-32445ddf0365"> | <video src="https://github.com/user-attachments/assets/2c8c29a2-157f-45ff-a598-cd10b5546045"> | | Android | <video src="https://github.com/user-attachments/assets/b41520b3-e9b4-4b45-b81b-3f6f96fb7ab9"> | <video src="https://github.com/user-attachments/assets/05924754-1dad-4135-aad4-6ddbe2410e44"> |
…ems when binding changes (#35217) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details - SwipeItem.IsVisible doesn't properly refresh the native swipe items when the binding value changes dynamically. SwipeItem is not a full VisualElement, so visibility changes does not trigger a native re-rendered. ### Root Cause - SwipeItem.IsVisibleProperty had no propertyChanged callback, so binding changes were never forwarded to the handler. On iOS, UpdateSwipeItems() recreates native views on every swipe-open and those views always defaulted to Hidden = false, ignoring the current binding value. On both iOS and Android, MapVisibility called UpdateIsVisibleSwipeItem (layout) before setting the native visibility. ### Description of Change - Added a propertyChanged callback (OnIsVisibleChanged) to the IsVisibleProperty in SwipeItem, ensuring that changes to visibility trigger UI updates. - Updated the MapVisibility method in both Android and iOS handlers to set the native view's visibility state before recalculating item positions, ensuring consistent UI behavior. - Modified the iOS platform code to set the Hidden property of swipe items during initialization, reflecting their initial visibility state. ### Issues Fixed Fixes #34832 ### Validated the behaviour in the following platforms - [ ] Windows - [x] Android - [x] iOS - [x] Mac ### Output | Platform | Before | After | |----------|----------|----------| | iOS | <video src="https://github.com/user-attachments/assets/febe78e5-10bd-4508-b7ac-32445ddf0365"> | <video src="https://github.com/user-attachments/assets/2c8c29a2-157f-45ff-a598-cd10b5546045"> | | Android | <video src="https://github.com/user-attachments/assets/b41520b3-e9b4-4b45-b81b-3f6f96fb7ab9"> | <video src="https://github.com/user-attachments/assets/05924754-1dad-4135-aad4-6ddbe2410e44"> |
## What's Coming .NET MAUI inflight/candidate introduces significant improvements across all platforms with focus on quality, performance, and developer experience. This release includes 153 commits with various improvements, bug fixes, and enhancements. ## Activityindicator - [Android] Fix CollectionView ActivityIndicator not animating after header height change by @Vignesh-SF3580 in #35358 <details> <summary>🔧 Fixes</summary> - [CollectionView items fail to update ActivityIndicator state after header height change](#33780) </details> ## Animation - [Android] Fix Shadow property affecting transform matrix. by @Shalini-Ashokan in #32962 <details> <summary>🔧 Fixes</summary> - [[Android] Applying Shadow property affects the properties in Visual Transform Matrix](#32731) </details> ## API - Add delegate-based alert dialog extensibility convention (no public API changes) by @Redth in #35095 <details> <summary>🔧 Fixes</summary> - [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`, `DisplayPromptAsync`) needs a public extensibility point](#34104) </details> ## Blazor - [Android] Fix for BlazorWebView predictive back callback blocks Android back-to-home animation by @BagavathiPerumal in #35538 <details> <summary>🔧 Fixes</summary> - [[Android] BlazorWebView predictive back callback blocks Android back-to-home animation](#35397) </details> - [Android] Fix BlazorWebView back callback can swallow the first Back press when its callback is stale-enabled by @devanathan-vaithiyanathan in #35611 <details> <summary>🔧 Fixes</summary> - [[inflight regression] Android BlazorWebView back callback can swallow the first Back press when its callback is stale-enabled](#35573) </details> ## Border - [Windows] Fixed the ContentView clip is not updated when wrapping inside the Border by @Ahamed-Ali in #30408 <details> <summary>🔧 Fixes</summary> - [[Windows] ContentView clip is not updated when wrapping inside the Border](#30404) </details> - Fix Border.StrokeDashArray leaks dashed Borders when using a shared Application resource by @devanathan-vaithiyanathan in #35544 <details> <summary>🔧 Fixes</summary> - [`Border.StrokeDashArray` leaks dashed Borders when using a shared Application resource](#35492) </details> - [Windows] Border: Add AutomationPeer support by @Vignesh-SF3580 in #35577 <details> <summary>🔧 Fixes</summary> - [Adding AutomationPeers to Windows Borders](#27627) </details> - [Windows] Fixed BoxView improper rendering inside Border by @Dhivya-SF4094 in #28465 <details> <summary>🔧 Fixes</summary> - [[Windows] Issues with BoxView Placement Inside Border](#19668) </details> ## Button - Prevent NullReferenceException in LayoutButton by @GamesAgeddon in #35284 <details> <summary>🔧 Fixes</summary> - [NullReferenceException on iOS in Button.LayoutButton from WrapperView.LayoutSubviews](#31048) </details> - Fix TextColor null reset to restore platform defaults on iOS and Android by @Shalini-Ashokan in #35563 <details> <summary>🔧 Fixes</summary> - [[Windows, Android, iOS & Mac]Button TextColor does not restore to platform default when reset to null after dynamic update](#35513) </details> ## CollectionView - Fix CollectionView grid spacing updates for first row and column by @KarthikRajaKalaimani in #34527 <details> <summary>🔧 Fixes</summary> - [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item Spacing - horizontally updating the spacing only applies to the second column](#34257) </details> - [MacCatalyst] Fix CollectionView Header/Footer Not Expanding to Content Width by @KarthikRajaKalaimani in #35213 <details> <summary>🔧 Fixes</summary> - [[MacOS][CV2] I8_View header and footer_Horizontal_View - Footer on the right doesn't adapt when resizing the window](#35113) </details> - [iOS/MacCatalyst] Fix IndicatorView not updating when IndicatorSize is changed to default value by @Shalini-Ashokan in #35215 <details> <summary>🔧 Fixes</summary> - [[iOS/MacCatalyst] IndicatorView does not update when IndicatorSize is dynamically changed to the default value](#35214) </details> - CollectionView selecteditem background lost if collectionview (or parent) IsEnabled changed. by @KarthikRajaKalaimani in #31540 <details> <summary>🔧 Fixes</summary> - [CollectionView selecteditem background lost if collectionview (or parent) IsEnabled changed.](#20615) </details> - [iOS/macOS] CollectionView: Fix FlowDirection not working on EmptyView by @Dhivya-SF4094 in #32674 <details> <summary>🔧 Fixes</summary> - [[iOS, MacOS] FlowDirection not working on EmptyView in CollectionView](#32404) - [[iOS, Mac] CollectionView EmptyViewTemplate content text is mirrored when FlowDirection is RightToLeft](#34522) </details> - Fix iOS CollectionView stale layout invalidations by @filipnavara in #35245 <details> <summary>🔧 Fixes</summary> - [[iOS] CollectionView tries to invalidate cells with invalid indexes](#35244) </details> - Fix Android grouped CollectionView header/footer rebind leak by @AdamEssenmacher in #35368 <details> <summary>🔧 Fixes</summary> - [Memory leak when scrolling a CollectionView with IsGrouped=true](#17698) </details> - [Windows] Fix for Item should scrolled based on the GroupHeaderTemplate by @SuthiYuvaraj in #28074 <details> <summary>🔧 Fixes</summary> - [I9_Scroll by object for grouped data - The group name is always pined at the top after clicking 'Scroll to Proboscis Monkey' button](#27922) </details> - [Android] Fix ScrollTo regression when IsGrouped true on CollectionView by @SubhikshaSf4851 in #35356 <details> <summary>🔧 Fixes</summary> - [[10.0.60] ScrollTo(0) not working anymore on CollectionView when IsGrouped="True"](#35313) </details> - [Android] Fix CollectionView scrolling performance regression by @devanathan-vaithiyanathan in #35379 <details> <summary>🔧 Fixes</summary> - [[10.0.60] CollectionView scrolling performance regression](#35344) </details> - Optimize parent dynamic resource refresh by @AdamEssenmacher in #35408 <details> <summary>🔧 Fixes</summary> - [Memory usage increases when scrolling collectionview if resources count is more than 191](#22053) </details> - Fix CI failure for CollectionView Scrolling Feature Tests due to PR #35379 by @devanathan-vaithiyanathan in #35536 - [iOS & Mac] CarouselViewController2 leaks on iOS/MacCatalyst due to unremoved orientation notification observer by @SubhikshaSf4851 in #35532 <details> <summary>🔧 Fixes</summary> - [CarouselViewController2 leaks on iOS/MacCatalyst due to unremoved orientation notification observer](#35472) </details> - Fix CollectionView.SelectedItems leaks popped views when bound to a retained ObservableCollection by @HarishwaranVijayakumar in #35558 <details> <summary>🔧 Fixes</summary> - [`CollectionView.SelectedItems` leaks popped views when bound to a retained `ObservableCollection`](#35497) </details> - Fix for Android - Dynamic Updates to CollectionView Header/Footer and Templates Are Not Displayed by @SuthiYuvaraj in #28904 <details> <summary>🔧 Fixes</summary> - [Android - Dynamic Updates to CollectionView Header/Footer and Templates Are Not Displayed](#28676) </details> - [Windows] Fix CarouselView EmptyView display when filtering to zero items by @Shalini-Ashokan in #29247 <details> <summary>🔧 Fixes</summary> - [[Windows] [Scenario Day] EmptyView using Template displayed at the same time as the content](#7150) </details> - [Android/iOS] Fix IsEnabled=False on CollectionView not working by @devanathan-vaithiyanathan in #27749 <details> <summary>🔧 Fixes</summary> - [[iOS/Android] CollectionView IsEnabled Not Working](#27770) </details> - Fix CarouselView.Loop property does not update dynamically and fails to maintain the scroll position when the loop value is changed at runtime by @devanathan-vaithiyanathan in #29527 <details> <summary>🔧 Fixes</summary> - [[Android] CarouselView.Loop = false causes crash on Android when changed at runtime](#29411) - [Loop Binding in CarouselView Not Updating Dynamically at Runtime](#29449) </details> - [iOS / Mac] Fix CollectionView.ScrollTo(index) silently failing whenIsGrouped="True" by @Dhivya-SF4094 in #35609 <details> <summary>🔧 Fixes</summary> - [CollectionView.ScrollTo(index) doesn't work correctly when IsGrouped="True" on iOS, MacCatalyst, and Windows](#35326) </details> - Fix Android nested carousel scrolling by @AdamEssenmacher in #35656 <details> <summary>🔧 Fixes</summary> - [Vertical scrolling not working for CarouselView and CustomLayouts](#7814) </details> - [Inflight regression] Fixed Test failures ModalTabbedPagePushAsyncShouldOverlayBottomNavigationView and GroupedCollectionViewScrollToIndexScrollsToCorrectItem by @Dhivya-SF4094 in #35823 - Fix CarouselView tests fail in June 8 Candidate by @devanathan-vaithiyanathan in #35825 ## Core - Reduce allocations on AnimationManager by @pictos in #35612 <details> <summary>🔧 Fixes</summary> - [AnimationManager is allocating a lot](#35654) </details> ## Core Lifecycle - Fix device test memory by @pictos in #35487 <details> <summary>🔧 Fixes</summary> - [Memory leak Device.Test pass with false positive](#35485) </details> ## Datepicker - Fix MacCatalyst DatePicker focus handling by @AdamEssenmacher in #35553 <details> <summary>🔧 Fixes</summary> - [[mauipalooza] DatePicker focus only works first time](#5947) </details> ## DateTimePicker - [Android] Fix DatePicker dialog dismisses after the device is rotated by @HarishwaranVijayakumar in #34980 <details> <summary>🔧 Fixes</summary> - [[Android] [Regression] DatePicker dialog dismisses after the device is rotated](#34973) </details> ## Docs - doc: Add paragraph to README.md explaining how to fetch the `maui` project templates by @durandt in #34561 ## Drawing - [Android] Fix LinearGradientBrush rendering as opaque black box by @SubhikshaSf4851 in #35299 <details> <summary>🔧 Fixes</summary> - [[Regression] LinearGradientBrush broken on Android in 10.0.60](#35280) - [10.0.60 breaks transparency on Brushes (on Android?)](#35354) </details> - Fix polygon points collection handler leak by @AdamEssenmacher in #35526 <details> <summary>🔧 Fixes</summary> - [PolygonHandler and PolylineHandler leak when Points is replaced before disconnect](#35387) </details> ## Editor - [iOS] Fix Editor losing scrollability after rotation when CharacterSpacing is applied by @Vignesh-SF3580 in #35309 <details> <summary>🔧 Fixes</summary> - [[.NET 10][iOS] D2 - Editor can't be scrolled after rotating simulator.](#35114) </details> - [Inflight/Candidate][iOS & Mac] Fix for Editor height inconsistency when VerticalTextAlignment is Center or End on iOS and MacCatalyst by @BagavathiPerumal in #35662 <details> <summary>🔧 Fixes</summary> - [[MAUI] D13_Customize_Text_Alignment - Text Editor Height is not consistent](#35615) </details> ## Entry - [iOS/Mac] Fix Entry clear button retaining tint color after TextColor is reset to null by @SyedAbdulAzeemSF4852 in #35177 <details> <summary>🔧 Fixes</summary> - [[iOS/Mac]Entry ClearButtonVisibility color does not reset when TextColor is set to null](#35076) </details> - [iOS/MacCatalyst] Fix Entry clear button appearing dimmed compared to TextColor by @SyedAbdulAzeemSF4852 in #35541 <details> <summary>🔧 Fixes</summary> - [[MacCatalyst] [Entry] ClearButtonVisibility color appears dimmed compared to TextColor](#35517) </details> - Fix pill-shaped focus ring on macOS 26 by @Dhivya-SF4094 in #35393 <details> <summary>🔧 Fixes</summary> - [.Net 10 Picker item not centered and wrong focus outline of Entry on Mac](#34899) </details> - Fix Entry select all text on refocus not working on WinUI by @kubaflo in #35383 ## Essentials - [Android] Fix Capture video crashes after stopping recording on Android 12 by @HarishwaranVijayakumar in #35638 <details> <summary>🔧 Fixes</summary> - [Capture video crashes after stopping recording on Android 12](#28891) </details> - [Essentials] Browser.OpenAsync(External): drop visibility-filtered ResolveActivity pre-check by @Kebechet in #35652 <details> <summary>🔧 Fixes</summary> - [Browser.OpenAsync(External) on Android throws FeatureNotSupportedException for verified App Link owner URLs even with documented <queries> fix applied](#35651) </details> ## Essentials Texttospeech - [Mac, iOS, Windows] Fix for inconsistent Text-to-Speech rate behavior by @HarishwaranVijayakumar in #32850 <details> <summary>🔧 Fixes</summary> - [[Essentials] TTS rate](#32492) </details> ## Flyoutpage - [iOS/Mac] Fix FlyoutPage RTL FlowDirection is not working by @devanathan-vaithiyanathan in #34831 <details> <summary>🔧 Fixes</summary> - [[iOS/Mac] FlyoutPage RTL FlowDirection is not working properly](#34830) </details> - [Android] Fix for Android 16 Back button is not working after command from FlyoutPage by @BagavathiPerumal in #35196 <details> <summary>🔧 Fixes</summary> - [Android: BackButton on Android 16 not working after command from FlyOutPage](#33508) </details> ## Gestures - Fix DragGestureRecognizer.DropCompleted event not firing in Android platform by @KarthikRajaKalaimani in #35179 <details> <summary>🔧 Fixes</summary> - [[Android] DragGestureRecognizer.DropCompleted event not firing](#17554) </details> - Windows: Ensure layouts without background participate in hit testing by @jpd21122012 in #34364 <details> <summary>🔧 Fixes</summary> - [[Windows] TapGestureRecognizer does NOT work on a ContentView without Background](#32279) </details> - [iOS] Fix VoiceOver dropping child labels on layouts with SemanticProperties.Hint or TapGestureRecognizer by @Vignesh-SF3580 in #35590 <details> <summary>🔧 Fixes</summary> - [[iOS] VoiceOver does not correctly describe View with GestureRecognizers](#34380) </details> ## Hybridwebview - Fix RemovePossibleQueryString to also strip URL fragments by @kubaflo in #35551 <details> <summary>🔧 Fixes</summary> - [HybridWebViewQueryStringHelper.RemovePossibleQueryString removes '?' but not other special characters e.g. '#'](#31472) </details> - [Revert] - [Windows] Fix WebView blank rendering when used with HybridWebView by @SubhikshaSf4851 in #35814 ## Image - Avoid image source layout invalidation for fixed-size views by @AdamEssenmacher in #35369 <details> <summary>🔧 Fixes</summary> - [Image source swaps thrash layout under fixed constraints, tanking frame rate when scrolling virtualized collections](#32457) </details> - [Windows] Fix Image layout inconsistency caused by async decode race in GetDesiredSize by @praveenkumarkarunanithi in #34699 <details> <summary>🔧 Fixes</summary> - [[Windows] Image cropping produces inconsistent results when window is minimized or resized](#32393) </details> - [Testing] Include more testing around Windows Image Aspect recent fixes by @kubaflo in #35620 <details> <summary>🔧 Fixes</summary> - [[Testing] Include more testing around Windows Image Aspect recent fixes](#31686) </details> - Revert PR #30068 — Fix FontImageSource centering regression on Windows by @Shalini-Ashokan in #35642 <details> <summary>🔧 Fixes</summary> - [[Windows] Image with FontImageSource is not centered and gets clipped when WidthRequest/HeightRequest equals FontImageSource Size](#35618) </details> - [Android] Fix screenshot from WebView content not working by @kubaflo in #35384 <details> <summary>🔧 Fixes</summary> - [[Android] Loading the captured screenshot from webview content to Image control does not visible](#30010) </details> ## Label - Improve label mapping performance and ensure complete coverage including ToPlatform and subsequent property changes by @Tamilarasan-Paranthaman in #31159 - Fix for Label.FormattedText leaks labels when shared FormattedString is stored in Application.Resources by @BagavathiPerumal in #35582 <details> <summary>🔧 Fixes</summary> - [`Label.FormattedText` leaks labels when shared `FormattedString` is stored in `Application.Resources`](#35495) </details> - [iOS] Fix Label Span formatting test failures on candidate branch by @Vignesh-SF3580 in #35815 ## Layout - [iOS, Mac] Fix Item spacing not properly applied between items in Horizontal LinearItemsLayout by @Dhivya-SF4094 in #35445 <details> <summary>🔧 Fixes</summary> - [[CollectionView2] Item spacing not properly applied between items in Horizontal LinearItemsLayout](#35429) </details> - [Windows] Add Automation Id support for Layouts. by @SubhikshaSf4851 in #35562 <details> <summary>🔧 Fixes</summary> - [[Windows] AutomationId does not work for ContentView, Layouts and controls that inherit them](#4715) </details> - Avoid layout diagnostics allocations without listeners by @AdamEssenmacher in #35475 <details> <summary>🔧 Fixes</summary> - [MAUI 10 layout diagnostics no-consumer path is not zero-allocation](#35473) </details> - [Windows/Android] FlexLayout: Fix wrap misalignment due to floating-point precision by @SuthiYuvaraj in #31341 <details> <summary>🔧 Fixes</summary> - [FlexLayout Wrap Misalignment with Dynamically-Sized Buttons in .NET MAUI](#30957) </details> ## Listview - Fix Binding for ListView.IsRefreshing by @bill2004158 in #28516 <details> <summary>🔧 Fixes</summary> - [Bind ListView.IsRefreshing is not work.](#28514) </details> ## Map - Fix iOS/Catalyst MapPool retention with MapElements by @AdamEssenmacher in #35480 <details> <summary>🔧 Fixes</summary> - [iOS/Mac Catalyst MapHandler leaks MAUI Map views and MapElements through MapPool](#35479) </details> - Fix Android map view lifecycle cleanup by @AdamEssenmacher in #35476 <details> <summary>🔧 Fixes</summary> - [Navigating to a page with Maps multiple times Increase RAM Usage but doesn't reduce it back after navigating back](#15257) </details> - Fix Android map element options retention by @AdamEssenmacher in #35634 <details> <summary>🔧 Fixes</summary> - [[Regression] [Android] [Maps] Map locks up after rendering 50 Polylines](#20502) </details> ## Menubar - [MacCatalyst] Fix KeyboardAccelerator with Cmd+Shift modifiers breaks entire MenuBarItem on Mac Catalyst by @KarthikRajaKalaimani in #35318 <details> <summary>🔧 Fixes</summary> - [[Bug] KeyboardAccelerator with Cmd+Shift modifiers breaks entire MenuBarItem on Mac Catalyst](#35279) </details> ## Navigation - [iOS, Mac] Fix OnBackButtonPressed not invoked for NavigationPage and Shell by @Dhivya-SF4094 in #35072 <details> <summary>🔧 Fixes</summary> - [On Screen Back Button Does Not Fire OnBackButtonPressed in Android](#9095) - [ContentPage's OnBackButtonPressed not invoked on iOS and MacCatalyst](#8296) </details> - Fix Android stale ContainerView root leak by @AdamEssenmacher in #35372 <details> <summary>🔧 Fixes</summary> - [Android: Stale ContainerView retains replaced FlyoutPage graph](#35371) </details> - [Android] Fix for predictive back-to-home animation blocked by unconditional back callback registration by @BagavathiPerumal in #35223 <details> <summary>🔧 Fixes</summary> - [OnBackInvokedCallbacks block back-to-home animation](#34594) - [Migrate to OnBackPressedCallback](#24752) </details> - Revert [Android, iOS] - Flyout icon should remain visible when a page is pushed onto a NavigationPage or Shell page with the back button disabled. by @praveenkumarkarunanithi in #35604 ## Picker - [iOS] Fix Picker CharacterSpacing lost after item selection when Title is set by @SyedAbdulAzeemSF4852 in #34974 <details> <summary>🔧 Fixes</summary> - [[iOS] Picker loses CharacterSpacing after item selection when Title is set](#34971) </details> - [iOS] Fix Picker CharacterSpacing ignored on initial load by @SyedAbdulAzeemSF4852 in #34957 <details> <summary>🔧 Fixes</summary> - [[iOS] Picker ignores CharacterSpacing on initial load](#34955) </details> - [Windows] Fix for Picker CharacterSpacing Not Being Applied to Title and Dropdown Items by @SyedAbdulAzeemSF4852 in #30612 <details> <summary>🔧 Fixes</summary> - [[Windows] Picker CharacterSpacing property not applied to Title and PickerItems text](#30464) </details> - Fix Picker SelectedIndex deferred initialization by @AdamEssenmacher in #35629 <details> <summary>🔧 Fixes</summary> - [Picker Attribute "SelectedIndex" Not being respected on page load on Android?](#9150) </details> ## Progressbar - Fix iOS ProgressBar bounding box by @AdamEssenmacher in #35507 <details> <summary>🔧 Fixes</summary> - [[iOS] ProgressBar and Label don't correctly obey height and width at the core level](#7935) </details> ## RadioButton - [Windows, Android] Fix Border Color and Border Width Not applying for Radio Button by @HarishwaranVijayakumar in #35616 <details> <summary>🔧 Fixes</summary> - [[Windows, Android] Border Color and Border Width Not applying for Radio Button.](#35587) </details> - [inflight/current] Fixes a CS0111 build failure in RadioButton.cs caused by a duplicate OnPropertyChanged override by @HarishwaranVijayakumar in #35631 - Revert - Fix TalkBack not correctly narrating RadioButtons with Content by @devanathan-vaithiyanathan in #35625 <details> <summary>🔧 Fixes</summary> - [[Android] MissingMethodException AccessibilityNodeInfoCompat.set_Checked(bool) on 10.0.70 due to AndroidX.Core 1.17 breaking change](#35584) </details> ## Refreshview - [Windows] Fix RefreshView IsRefreshing property not working while binding by @devanathan-vaithiyanathan in #34845 <details> <summary>🔧 Fixes</summary> - [[Windows] RefreshView IsRefreshing property not working while binding](#30535) </details> - [Android] Fix for RefreshView triggering pull-to-refresh when scrolling inside a WebView with internal scrollable content by @BagavathiPerumal in #34614 <details> <summary>🔧 Fixes</summary> - [[Android] RefreshView triggers pull-to-refresh immediately when scrolling up inside a WebView](#33510) </details> ## SafeArea - [Android] Fix bottom safe area padding dropping to zero when keyboard is shown by @praveenkumarkarunanithi in #35084 <details> <summary>🔧 Fixes</summary> - [[Android] Bottom insets issues when keyboard is shown.](#32871) </details> - Gate SafeArea inset listeners in recycler items by @AdamEssenmacher in #35664 <details> <summary>🔧 Fixes</summary> - [[10.0.60] CollectionView scrolling performance regression](#35344) </details> ## ScrollView - [Windows] Fix COMException when restoring a ScrollView as ContentPage.Content after swapping it out by @Vignesh-SF3580 in #35360 <details> <summary>🔧 Fixes</summary> - [COMException when clone a page's content to a object and set it back later in mainthread on Windows](#35277) </details> - Fix - ScrollView.ScrollToAsync(x, y, animated) doesn't work when called from Page.OnAppearing by @Shalini-Ashokan in #35395 <details> <summary>🔧 Fixes</summary> - [[iOS] ScrollView.ScrollToAsync(x, y, animated) doesn't work when called from Page.OnAppearing](#31177) </details> ## Searchbar - [Android] Fix SearchBar IME full-screen extract mode in landscape orientation by @SubhikshaSf4851 in #35197 <details> <summary>🔧 Fixes</summary> - [[Android] Investigate SearchBar presentation in horizontal screen orientation ](#14708) </details> - [iOS 26] Fix SearchBar layout spacing issues for small HeightRequest values by @devanathan-vaithiyanathan in #35347 <details> <summary>🔧 Fixes</summary> - [Spacing problem with maui 10.0.60 iOS](#35286) </details> ## SearchBar - [Windows] Fix SearchHandler does not focus when ShowSoftInputAsync is called by @praveenkumarkarunanithi in #35079 <details> <summary>🔧 Fixes</summary> - [[Windows] SearchHandler.ShowSoftInputAsync() does not focus the SearchHandler](#34930) </details> ## Shell - Fix Android layout jump when navigating with IME open and NavBarIsVisible=false by @jpd21122012 in #34621 <details> <summary>🔧 Fixes</summary> - [Shell page without NavBar jumping when navigating with keyboard open](#34584) </details> - [Android] Add defensive not null check to SearchHandlerAppearanceTracker.FocusChange by @Transis-Felipe in #29939 - [Android] Fix for Shell colors change before navigation completes on Android in .NET 10 by @BagavathiPerumal in #35295 <details> <summary>🔧 Fixes</summary> - [Shell colors change before navigation completes on Android in .NET 10](#35060) </details> - [Windows] Fix Shell FlyoutItem not taking full width by @SubhikshaSf4851 in #35131 <details> <summary>🔧 Fixes</summary> - [MAUI WinUI Grids don't render properly in flyout menu](#19542) - [[Windows] [.NET 8 RC2] FlyoutItem Backgroundcolor Is not fully displaying](#18238) </details> - [Android, iOS, Catalyst] Fix SearchHandler.BackgroundColor cannot be reset to null by @HarishwaranVijayakumar in #35224 <details> <summary>🔧 Fixes</summary> - [[Android, iOS, Catalyst] SearchHandler.BackgroundColor cannot be reset to null](#35088) </details> - Fix for ApplyQueryAttributes being called on non-destination pages during back navigation by @BagavathiPerumal in #35392 <details> <summary>🔧 Fixes</summary> - [ApplyQueryAttributes gets called for not activated (navigated to) page on back](#35183) </details> - [Android] Fix Shell flyout background to follow Material 3 theme colors by @SyedAbdulAzeemSF4852 in #35148 <details> <summary>🔧 Fixes</summary> - [[Android] Shell Flyout ignores Material 3 surface color when UseMaterial3 is enabled](#35147) </details> - [Android] Fix Shell.FlyoutHeader background incorrect by @SyedAbdulAzeemSF4852 in #35489 <details> <summary>🔧 Fixes</summary> - [[Android] Shell.FlyoutHeader background is incorrect](#35416) </details> - [iOS/MacCatalyst] Fix Shell.BackgroundColor not applied to bottom TabBar by @Shalini-Ashokan in #35545 <details> <summary>🔧 Fixes</summary> - [[MacCatalyst] Shell.BackgroundColor not applied to bottom TabBar](#35380) - [[Catalyst] Shell.TabBarBackgroundColor is not applied](#35381) </details> - [Android] Fix Shell FlyoutIcon tint loss after navigation by @SyedAbdulAzeemSF4852 in #35561 <details> <summary>🔧 Fixes</summary> - [[Android] The flyout icon loses colours](#35390) </details> - [iOS] Fix Shell - opened keyboard on modal page shifts parent page/frame behind modal after update to 10.0.60 by @KarthikRajaKalaimani in #35559 <details> <summary>🔧 Fixes</summary> - [[iOS] Shell - opened keyboard on modal page shifts parent page/frame behind modal after update to 10.0.60](#35401) </details> - Fix intermediate pages not receiving query parameters in multi-page Shell navigation by @mattleibow in #35432 <details> <summary>🔧 Fixes</summary> - [Shell GoToAsync: no way to pass query parameters to intermediate pages in multi-segment navigation](#35107) </details> - [Windows] Fix Shell title bar overlap with window controls in RTL mode by @Shalini-Ashokan in #33109 <details> <summary>🔧 Fixes</summary> - [[Windows] Binding RTL FlowDirection in Shell causes Flyout MenuIcon and native window controls to overlap](#32476) </details> - [macOS] Fix IsEnabled property false not working on MenuBarItem by @devanathan-vaithiyanathan in #35546 <details> <summary>🔧 Fixes</summary> - [[macOS] IsEnabled property false not working on MenuBarItem](#34038) </details> - Fix Android Shell top inset when nav bar is hidden by @ne0rrmatrix in #35555 <details> <summary>🔧 Fixes</summary> - [wrong statusbar height when Android device has a notch](#35103) </details> - Fix Changing Content property of ShellContent doesn't change visual content by @devanathan-vaithiyanathan in #34630 <details> <summary>🔧 Fixes</summary> - [Changing Content property of ShellContent doesn't change visual content. ](#12669) </details> - Fixed a NullReferenceException when starting application with empty shell on Windows by @Shalini-Ashokan in #28879 <details> <summary>🔧 Fixes</summary> - [NullReferenceException when starting application with empty shell on Windows](#21562) - [Using SelectionChangedCommand with CollectionView in Shell.FlyoutContent results in Win32 Unhandled Exception](#10041) </details> ## Slider - [iOS] Slider: Scale ThumbImageSource to match default thumb size by @NirmalKumarYuvaraj in #34184 <details> <summary>🔧 Fixes</summary> - [[Slider] MAUI Slider thumb image is big on android](#13258) </details> ## Stepper - Fix iOS 26 Stepper overlap in landscape by @AdamEssenmacher in #35374 <details> <summary>🔧 Fixes</summary> - [[.NET10] D10-The number and buttons overlap after rotating the simulator.](#35211) </details> ## SwipeView - Fix SwipeViews with invoked properties crash the app in Release mode by @BagavathiPerumal in #35208 <details> <summary>🔧 Fixes</summary> - [[iOS/Catalyst] Swipeviews with invoked properties crash the app in Release](#18055) </details> - Fix SwipeItemView command leak by @AdamEssenmacher in #35510 <details> <summary>🔧 Fixes</summary> - [`SwipeItemView.Command` leaks row views and command parameters through `CanExecuteChanged`](#35498) </details> - [iOS/Android] Fix SwipeItem.IsVisible not refreshing native swipe items when binding changes by @SyedAbdulAzeemSF4852 in #35217 <details> <summary>🔧 Fixes</summary> - [SwipeItem.IsVisible doesn't properly refresh the native swipe items when the binding value changes dynamically](#34832) </details> - Fix SwipeView memory leak when SwipeItems are reused or replaced by @Vignesh-SF3580 in #35539 <details> <summary>🔧 Fixes</summary> - [SwipeView leaks when SwipeItems are reused or replaced](#35481) </details> - Fix SwipeItem IconImageSource color handling and rendering across platforms by @Shalini-Ashokan in #35632 <details> <summary>🔧 Fixes</summary> - [[Android] SwipeItem IconImageSource should allow more configuration](#23074) </details> ## Switch - [Android/Windows] Fix RadioButton gradient not clearing when switching background by @Shalini-Ashokan in #34997 <details> <summary>🔧 Fixes</summary> - [RadioButton Background does not reset when set to null at runtime](#34993) </details> - [Windows] Fix "PlatformView cannot be null here" exception during handler disconnect by @kubaflo in #35314 <details> <summary>🔧 Fixes</summary> - ["PlatformView cannot be null here" Exception in Switch control [Windows]](#27101) </details> - [iOS 26] Fix Switch ThumbColor and OffColor not applied on initial load by @SyedAbdulAzeemSF4852 in #35400 <details> <summary>🔧 Fixes</summary> - [iOS 26 Switch default color for Off and On is incorrect + Off Color is not applied at start + Thumb Colors is not applied](#35257) </details> - [Android] Fix AppBar flicker on CheckBox/Switch toggle with Material 3 by @Dhivya-SF4094 in #35181 <details> <summary>🔧 Fixes</summary> - [[Android] AppBar flicker while changing the CheckBox or Switch state after scrolling in Material 3](#35180) </details> - [Android] Fix Switch Shadow Does Not Follow Thumb when Toggle On or Off by @Dhivya-SF4094 in #35623 <details> <summary>🔧 Fixes</summary> - [[Android] Switch Shadow Does Not Follow Thumb when Toggle On or Off](#30046) </details> ## TabbedPage - [Android] Fix TabbedPage truncating tab titles instead of scrolling by @Shalini-Ashokan in #35086 <details> <summary>🔧 Fixes</summary> - [Maui migrating Xamarin to Maui - Tabbed Page Scroll Issue - Tabs are not scrolling](#16470) </details> - [Android] Fix BottomNavigationView remaining visible for TabbedPage inside modal NavigationPage after PushAsync by @Dhivya-SF4094 in #35359 <details> <summary>🔧 Fixes</summary> - [Android TabbedPage inside Modal Navigation does not overlay BottomNavigationView after PushAsync in .NET MAUI 10.0.60](#35331) </details> - [Android & iOS] TabbedPage leaks with shared GradientBrush. by @SubhikshaSf4851 in #35543 <details> <summary>🔧 Fixes</summary> - [TabbedPage leaks renderer/manager when BarBackground uses shared GradientBrush resource](#35469) </details> ## Templates - Bumps Syncfusion.Maui.Toolkit dependency to version 1.0.10 by @PaulAndersonS in #35608 ## Toolbar - Fix Android app bar inset background coloring by @ne0rrmatrix in #35601 <details> <summary>🔧 Fixes</summary> - [Android Edge-to-Edge: Shell and NavigationPage Top Bar colour is not used for status bar.](#35568) </details> ## Tooling - Add default .gitignore to MAUI project templates by @davidortinau in #34862 <details> <summary>🔧 Fixes</summary> - [Add a gitignore file to the Maui template in VS 2022](#4131) </details> - Fix: Propagate AdditionalProperties from ProjectReference in ResizetizeCollectItems by @mattleibow in #35575 <details> <summary>🔧 Fixes</summary> - [Resizetizer GetMauiItems does not propagate ProjectReference AdditionalProperties](#35574) </details> ## WebView - [Windows] Fix WebView blank rendering when used with HybridWebView by @SubhikshaSf4851 in #35092 <details> <summary>🔧 Fixes</summary> - [[Windows] WebView Regression from NET9 to NET10](#34558) </details> - Fix AOT integration test failures: suppress IL3050/IL2026 for HybridWebViewHandler in AddControlsHandlers by @mattleibow via @Copilot in #34868 - Fix Android activity result callback leak by @AdamEssenmacher in #35436 <details> <summary>🔧 Fixes</summary> - [Android WebView file chooser callbacks leak via ActivityResultCallbackRegistry](#35405) </details> - [Windows] Fix WebView Does Not Inherit App Theme by @devanathan-vaithiyanathan in #35037 <details> <summary>🔧 Fixes</summary> - [WebView on Windows Does Not Inherit App Theme](#34823) </details> - Fix for WebView leaks when reusing a shared WebViewSource by @BagavathiPerumal in #35524 <details> <summary>🔧 Fixes</summary> - [WebView leaks when reusing a shared WebViewSource](#35483) </details> - Destroy Android WebView on handler disconnect by @AdamEssenmacher in #35552 <details> <summary>🔧 Fixes</summary> - [Right way to dispose page with WebView](#18021) </details> ## Xaml - Fix: Enable VisualStateManager to set Style property dynamically by @Shalini-Ashokan in #33389 <details> <summary>🔧 Fixes</summary> - [Setting the `Style` property using the `VisualStateManager` within a Style resource does not work](#17175) </details> - Fix Implicit parameter conversion from integer to byte fails with source generated XAML by @KarthikRajaKalaimani in #35444 <details> <summary>🔧 Fixes</summary> - [Implicit parameter conversion from integer to byte fails with source generated XAML](#35396) </details> <details> <summary>🔧 Infrastructure (3)</summary> - Fix: Build fails when appicon is an empty (but valid) SVG by @Shalini-Ashokan in #35305 <details> <summary>🔧 Fixes</summary> - [Build fails when appicon is an empty (but valid) svg after upgrade to 10.0.60](#35293) </details> - [inflight/current] Fix CS0111 duplicate GetNativeCharacterSpacing in PickerHandlerTests.iOS by @SyedAbdulAzeemSF4852 in #35419 - Update WinAppSDK to 1.8.260508005 by @kubaflo in #35678 </details> <details> <summary>🧪 Testing (3)</summary> - Backport Test Fixes and Snapshots from SR to Inflight Branch by @Tamilarasan-Paranthaman in #35499 - Fix hardcoded version of Microsoft.DotNet.XHarness.TestRunners.Xunit in test projects by @akoeplinger in #29905 - [Testing] Fixed Build error on inflight/ candidate PR 35716 by @HarishKumarSF4517 in #35730 </details> <details> <summary>🏠 Housekeeping (1)</summary> - [HouseKeeping] Fix inconsistant namespace in HostApp by @NirmalKumarYuvaraj in #35210 </details> <details> <summary>📦 Other (8)</summary> - Add .cab and ReconnectModal.razor.js to signing config by @jesuszarate in #35026 - Fix typo in Clipboard.shared.cs by @Deadpikle in #35316 - Fix single modifier for NSMenuItem accelerators by @jeremy-visionaid in #35351 - Avoid unnecessary LINQ enumerations by @jeremy-visionaid in #35272 - [Testing] Replace retryDelay with retryTimeout in UI tests by @kubaflo in #35367 - Replace JavaFinalize() with Dispose(bool) in GenericAnimatorListener by @jonathanpeppers in #35548 - Fix incorrect SDK provisioning commands in integration-tests instructions by @davidnguyen-tech in #34992 - Fix VisualElement.ChangeVisualState() gets stuck in Selected state by @Dhivya-SF4094 in #35421 <details> <summary>🔧 Fixes</summary> - [VisualElement's ChangeVisualState gets stuck in Selected state](#35399) </details> </details> <details> <summary>📝 Issue References</summary> Fixes #4131, Fixes #4715, Fixes #5947, Fixes #7150, Fixes #7814, Fixes #7935, Fixes #8296, Fixes #9095, Fixes #9150, Fixes #10041, Fixes #12669, Fixes #13258, Fixes #14708, Fixes #15257, Fixes #16470, Fixes #17175, Fixes #17554, Fixes #17698, Fixes #18021, Fixes #18055, Fixes #18238, Fixes #19542, Fixes #19668, Fixes #20502, Fixes #20615, Fixes #21562, Fixes #22053, Fixes #23074, Fixes #24752, Fixes #27101, Fixes #27627, Fixes #27770, Fixes #27922, Fixes #28514, Fixes #28676, Fixes #28891, Fixes #29411, Fixes #29449, Fixes #30010, Fixes #30046, Fixes #30404, Fixes #30464, Fixes #30535, Fixes #30957, Fixes #31048, Fixes #31177, Fixes #31472, Fixes #31686, Fixes #32279, Fixes #32393, Fixes #32404, Fixes #32457, Fixes #32476, Fixes #32492, Fixes #32731, Fixes #32871, Fixes #33508, Fixes #33510, Fixes #33780, Fixes #34038, Fixes #34104, Fixes #34257, Fixes #34380, Fixes #34522, Fixes #34558, Fixes #34584, Fixes #34594, Fixes #34823, Fixes #34830, Fixes #34832, Fixes #34899, Fixes #34930, Fixes #34955, Fixes #34971, Fixes #34973, Fixes #34993, Fixes #35060, Fixes #35076, Fixes #35088, Fixes #35103, Fixes #35107, Fixes #35113, Fixes #35114, Fixes #35147, Fixes #35180, Fixes #35183, Fixes #35211, Fixes #35214, Fixes #35244, Fixes #35257, Fixes #35277, Fixes #35279, Fixes #35280, Fixes #35286, Fixes #35293, Fixes #35313, Fixes #35326, Fixes #35331, Fixes #35344, Fixes #35354, Fixes #35371, Fixes #35380, Fixes #35381, Fixes #35387, Fixes #35390, Fixes #35396, Fixes #35397, Fixes #35399, Fixes #35401, Fixes #35405, Fixes #35416, Fixes #35429, Fixes #35469, Fixes #35472, Fixes #35473, Fixes #35479, Fixes #35481, Fixes #35483, Fixes #35485, Fixes #35492, Fixes #35495, Fixes #35497, Fixes #35498, Fixes #35513, Fixes #35517, Fixes #35568, Fixes #35573, Fixes #35574, Fixes #35584, Fixes #35587, Fixes #35615, Fixes #35618, Fixes #35651, Fixes #35654 </details> **Full Changelog**: main...inflight/candidate
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
Root Cause
Description of Change
Issues Fixed
Fixes #34832
Validated the behaviour in the following platforms
Output
iOS_Before.mov
iOS_After.mov
Android_Before.mov
Android_After.mov