Fix: Propagate AdditionalProperties from ProjectReference in ResizetizeCollectItems

[mattleibow]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description

Fixes #35574

In Microsoft.Maui.Resizetizer.After.targets, the ResizetizeCollectItems target calls GetMauiItems on referenced projects but only passes TargetFramework — it does NOT propagate AdditionalProperties from the ProjectReference items. This means any conditional item removal in the referenced project (like stripping MauiIcon when IsTestLibrary=true) is ignored during Resizetizer's collection, causing duplicate filename errors.

Changes

Fix (Microsoft.Maui.Resizetizer.After.targets)

1. Added an Update step that copies AdditionalProperties metadata from matching ProjectReference items to _ResizetizeCollectItemsProject
2. Appended %(_ResizetizeCollectItemsProject.AdditionalProperties) to the Properties parameter in the <MSBuild> task call

Tests (ResizetizerTests.cs)

Two new integration tests validate the fix:

• AdditionalPropertiesExcludesImage — Verifies that setting ExcludeLibraryImage=true via AdditionalProperties causes the library to conditionally remove its MauiImage, preventing it from being collected by the app
• AdditionalPropertiesPassesColorToLibrary — Verifies that a Color property override flows through AdditionalProperties and is used when processing the library image

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35575

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35575"

[mattleibow]

/review

[kubaflo]

/review -b feature/regression-check

[MauiBot]

Expert Review — 1 findings

See inline comments for details.

[MauiBot]

[moderate] Regression Prevention and Test Coverage - This test does not actually verify that LibraryImageColor flowed through ProjectReference AdditionalProperties. It only asserts that the Android PNG exists, which would still pass without the fix because the referenced project would fall back to the default #0000FF and still produce an image. Please assert the propagated color via generated metadata/inputs or inspect the output image so this test fails when AdditionalProperties is not passed.

[MauiBot]

🤖 AI Summary

👋 @mattleibow — new AI review results are available. Please review the latest session below.

📊 Review Session — efd61d1 · Simplify fix: remove unnecessary Update step · 2026-05-22 11:23 UTC

🚦 Gate — Test Before & After Fix

Gate Result: ⚠️ SKIPPED

No tests were detected in this PR.

Recommendation: Add tests to verify the fix using the write-tests-agent.

---

🧪 UI Tests

No UI test categories needed for this PR (no UI-relevant changes).

---

🔍 Regression Cross-Reference

🟢 No implementation files modified — skipping regression cross-reference.

---

🔍 Pre-Flight — Context & Validation

Issue: #35574 - Resizetizer GetMauiItems does not propagate ProjectReference AdditionalProperties
PR: #35575 - Fix: Propagate AdditionalProperties from ProjectReference in ResizetizeCollectItems
Platforms Affected: Android primarily; Resizetizer target behavior can affect all MAUI target frameworks that collect items from project references.
Files Changed: 1 implementation, 1 test

Key Findings

• ResizetizeCollectItems invokes GetMauiItems for referenced projects. The bug is that per-reference properties such as AdditionalProperties="IsTestLibrary=true"/ExcludeLibraryImage=true must be visible when the referenced project evaluates conditional MauiIcon, MauiSplashScreen, or MauiImage removals.
• PR implementation appends %(_ResizetizeCollectItemsProject.AdditionalProperties) to the MSBuild task Properties parameter in Microsoft.Maui.Resizetizer.After.targets.
• PR adds integration tests, but the prior gate result was skipped because no tests were detected by the gate script. The added AdditionalPropertiesExcludesImage test covers the core regression; AdditionalPropertiesPassesColorToLibrary only checks image existence and does not prove color propagation.
• No PR inline review comments were present. Prior PR comments only requested review.

Code Review Summary

Verdict: LGTM
Confidence: medium
Errors: 0 | Warnings: 1 | Suggestions: 0

Key code review findings:

• ⚠️ src/TestUtils/src/Microsoft.Maui.IntegrationTests/ResizetizerTests.cs:245-249 — AdditionalPropertiesPassesColorToLibrary can pass without proving propagation because it only asserts generated image existence.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #35575	Append %(_ResizetizeCollectItemsProject.AdditionalProperties) to the MSBuild task properties for GetMauiItems.	⚠️ Gate skipped (no tests detected)	Microsoft.Maui.Resizetizer.After.targets, ResizetizerTests.cs	Original PR fix; focused repro also passed when resolved-reference metadata carries AdditionalProperties.

---

🔬 Code Review — Deep Analysis

Code Review — PR #35575

Independent Assessment

What this changes: ResizetizeCollectItems now passes ProjectReference AdditionalProperties into the MSBuild call that invokes GetMauiItems on referenced projects.
Inferred motivation: Referenced MAUI projects may conditionally include/remove resizetizer items based on per-reference properties; previously those conditions were ignored during transitive item collection.

Reconciliation with PR Narrative

Author claims: The PR fixes missing AdditionalProperties propagation and adds two integration tests.
Agreement/disagreement: The code change matches the intended fix. The PR description still mentions an Update step that is no longer in the final diff, but the remaining one-line fix appears intentional. The exclusion test validates the bug; the color test is weaker than described.

Findings

⚠️ Warning — Color propagation test can pass without proving propagation

src/TestUtils/src/Microsoft.Maui.IntegrationTests/ResizetizerTests.cs:245-249

AdditionalPropertiesPassesColorToLibrary sets LibraryImageColor=%23FF0000, but only asserts that the generated image exists. Without the fix, the library still produces the image using the default #0000FF, so this test can pass even if AdditionalProperties is not propagated. The exclusion test does cover the core regression, but this second test does not verify its stated behavior.

Devil's Advocate

The MSBuild target change appends semicolon-delimited properties in the expected format, and %23 is appropriate for the # color value. The main risk is whether metadata survives the resolved-reference transformation, but the new exclusion test should catch that path if CI executes it. Required CI was still queued/in progress when checked; no failures were observed.

Verdict: LGTM

Confidence: medium
Summary: The implementation looks correct and the primary regression test should catch the missing-property bug. The color test should be strengthened, but it is not blocking because the exclusion test exercises the important behavior.

---

🔧 Fix — Analysis & Comparison

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix	Build _ResizetizeCollectItemsProject from @(ProjectReference) to preserve original metadata, then overlay resolved NearestTargetFramework.	✅ PASS	1 file	Passed focused Android MSBuild repro, but rewrites item construction and adds path-matching/batching risk.
2	try-fix	Keep resolved-reference-first construction and explicitly copy %(ProjectReference.AdditionalProperties) onto _ResizetizeCollectItemsProject.	✅ PASS	1 file	Passed focused repro; narrower than #1, but potentially redundant with PR if resolved-reference metadata already carries AdditionalProperties.
3	try-fix	Use PrepareProjectReferences/@(_MSBuildProjectReferenceExistent) and standard ProjectReference property metadata (SetTargetFramework, AdditionalProperties, RemoveProperties).	✅ PASS	1 file	Passed focused repro, but changes target ordering/source items and relies on prepared MSBuild internals.
PR	PR #35575	Append %(_ResizetizeCollectItemsProject.AdditionalProperties) to the existing MSBuild task Properties parameter.	⚠️ Gate skipped; focused repro PASS	2 files	Smallest production change; code review found no blocking implementation issue.

Cross-Pollination

Model	Round	New Ideas?	Details
maui-expert-reviewer	2	No	NO NEW IDEAS — attempts cover the meaningful design space: pass existing resolved metadata, rehydrate it from ProjectReference, or switch to the standard project-reference pipeline.

Exhausted: Yes
Selected Fix: PR's fix — It is the simplest production change and passes the same focused repro under the metadata shape expected from resolved project references. Candidate #2 is the best fallback if maintainers want explicit metadata rehydration, but it was not demonstrably better than the PR fix in validation.

---

📋 Report — Final Recommendation

Comparative Report - PR #35575

Candidate Ranking

Rank	Candidate	Regression result	Assessment
1	pr-plus-reviewer	Gate skipped; focused Android repro PASS	Same minimal production fix as the PR, plus the expert reviewer's actionable test improvement so the color test proves AdditionalProperties propagation instead of only checking image existence.
2	pr	Gate skipped; focused Android repro PASS	Smallest production change: appends %(_ResizetizeCollectItemsProject.AdditionalProperties) to the existing MSBuild call. The implementation is sound if resolved project-reference items already carry the original metadata, but one new test is ineffective.
3	try-fix-2	PASS	Keeps the current resolved-reference-first flow and explicitly copies %(ProjectReference.AdditionalProperties) onto _ResizetizeCollectItemsProject. This is the best fallback if maintainers are concerned the PR's transformed item metadata may be absent, but it adds an extra metadata update that the focused repro did not prove necessary.
4	try-fix-1	PASS	Builds collection items from @(ProjectReference) to preserve original metadata, then overlays NearestTargetFramework. It passes the repro, but rewrites item construction and introduces more path-matching/batching risk than the PR.
5	try-fix-3	PASS	Switches to PrepareProjectReferences/@(_MSBuildProjectReferenceExistent) and standard ProjectReference metadata. It is semantically broad, but changes target ordering and depends on prepared MSBuild internals, making it riskier than the narrower fixes.

No candidate failed the focused regression validation recorded in STEP 6a. The skipped gate does not rank any candidate above a passing candidate because the gate was skipped due to no detected tests, not due to candidate failure.

Winner

pr-plus-reviewer wins. It preserves the PR's minimal production behavior, addresses the only expert-review finding by strengthening test coverage, and avoids the broader target-ordering and item-construction changes in the try-fix alternatives.

Notes for PR Follow-up

The PR description should be corrected before merge: it claims an Update step copies AdditionalProperties metadata, but the submitted production diff only appends existing _ResizetizeCollectItemsProject.AdditionalProperties to the nested MSBuild Properties parameter.

---

[kubaflo]

/review

[MauiBot]

Expert Review — 1 findings

See inline comments for details.

[MauiBot]

[moderate] Build & MSBuild — Appending AdditionalProperties after the negotiated TargetFramework lets a referenced project override NearestTargetFramework if its AdditionalProperties contains TargetFramework=.... Concrete scenario: an app building net*-android references a multi-targeted library with AdditionalProperties="IsTestLibrary=true;TargetFramework=net*"; GetMauiItems would then run for the non-Android TFM instead of the resolved nearest TFM, collecting the wrong asset set. Please put the supplemental properties before the explicit TargetFramework assignment or filter TargetFramework out before appending.

[kubaflo]

/review -b feature/refactor-copilot-yml

[MauiBot]

Expert Review — 1 findings

See inline comments for details.

[MauiBot]

[moderate] Build & MSBuild - AdditionalProperties is appended after the computed TargetFramework, so a project reference that includes AdditionalProperties="TargetFramework=..." can override NearestTargetFramework for this GetMauiItems call. That can make resizetizer collect items from the wrong TFM/platform. Put AdditionalProperties first and TargetFramework=%(_ResizetizeCollectItemsProject.NearestTargetFramework) last so the resolved nearest TFM remains authoritative while still flowing the extra properties.

[kubaflo]

/review -b feature/refactor-copilot-yml

[kubaflo]

Could you check the ai's suggestions?